From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [pyro][PATCH] bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
Date: Thu, 1 Feb 2018 12:22:18 +0000 [thread overview]
Message-ID: <20180201122218.4533-1-Martin.Jansa@gmail.com> (raw)
From: Chen Qi <Qi.Chen@windriver.com>
Add tools required by testimage to HOSTTOOLS only when testimage is
inherited. These tools, as described in the comment, are only required
by the testimage task. So this change should not have negtive effect.
This would also solve build error on hosts which miss some tool such as scp.
Cherry-picked from rocko 8ca61a5464743ff85b6d26886112750d6ddd13e0
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta/conf/bitbake.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 2dac3a1481..f3994fc642 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -469,7 +469,7 @@ HOSTTOOLS += " \
"
# Tools needed to run testimage runtime image testing
-HOSTTOOLS += "ip ping ps scp ssh stty"
+HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
# Link to these if present
HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
--
2.15.1
next reply other threads:[~2018-02-01 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 12:22 Martin Jansa [this message]
2018-02-11 16:44 ` [pyro][PATCH] bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally Martin Jansa
2018-02-12 10:19 ` [pyro][PATCH] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL Martin Jansa
2018-03-04 11:41 ` Martin Jansa
2018-03-04 13:20 ` Richard Purdie
2018-03-04 13:24 ` Martin Jansa
2018-02-12 10:34 ` ✗ patchtest: failure for bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally (rev3) Patchwork
2018-03-04 11:41 ` [pyro][PATCH] bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201122218.4533-1-Martin.Jansa@gmail.com \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox