From: Matt Madison <matt@madison.systems>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v4 04/13] go.bbclass: remove debug-related commands
Date: Fri, 2 Mar 2018 12:33:05 -0800 [thread overview]
Message-ID: <20180302203314.32737-5-matt@madison.systems> (raw)
In-Reply-To: <20180302203314.32737-1-matt@madison.systems>
The 'go env' in the do_compile function and
the set -x/+x in the do_install_ptest function
were used for debugging the bbclass, and aren't
really needed.
Signed-off-by: Matt Madison <matt@madison.systems>
---
meta/classes/go.bbclass | 3 ---
1 file changed, 3 deletions(-)
diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
index 805d92e101..33a6fff0cd 100644
--- a/meta/classes/go.bbclass
+++ b/meta/classes/go.bbclass
@@ -88,7 +88,6 @@ go_do_configure() {
do_configure[dirs] =+ "${GOTMPDIR}"
go_do_compile() {
- ${GO} env
if [ -n "${GO_INSTALL}" ]; then
if [ -n "${GO_LINKSHARED}" ]; then
${GO} install ${GOBUILDFLAGS} `go_list_packages`
@@ -124,7 +123,6 @@ go_do_install() {
}
do_install_ptest_base() {
-set -x
test -f "${B}/.go_compiled_tests.list" || exit 0
tests=""
while read test; do
@@ -158,7 +156,6 @@ EOF
else
rm -rf ${D}${PTEST_PATH}
fi
-set +x
}
EXPORT_FUNCTIONS do_unpack do_configure do_compile do_install
--
2.14.1
next prev parent reply other threads:[~2018-03-02 20:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 20:33 [PATCH v4 00/13] go1.10 update and misc improvements Matt Madison
2018-03-02 20:33 ` [PATCH v4 01/13] go: update go 1.9 -> go 1.10 Matt Madison
2018-03-02 20:33 ` [PATCH v4 02/13] go: set GOMIPS envrionment variable Matt Madison
2018-03-02 20:33 ` [PATCH v4 03/13] go.bbclass: rename GO_TMPDIR -> GOTMPDIR Matt Madison
2018-03-02 20:33 ` Matt Madison [this message]
2018-03-02 20:33 ` [PATCH v4 05/13] go.bbclass: don't stage test data with sources Matt Madison
2018-03-02 20:33 ` [PATCH v4 06/13] go.bbclass: ptest cleanup and improvements Matt Madison
2018-03-02 20:33 ` [PATCH v4 07/13] goarch.bbclass: disable shared runtime for nativesdk builds Matt Madison
2018-03-02 20:33 ` [PATCH v4 08/13] go: move common settings to go-common.inc Matt Madison
2018-03-02 20:33 ` [PATCH v4 09/13] go.bbclass, goarch.bbclass: update SECURITY_CFLAGS Matt Madison
2018-03-02 20:33 ` [PATCH v4 10/13] go: disable PIE CFLAGS for nativesdk and cross-canadian builds Matt Madison
2018-03-02 20:33 ` [PATCH v4 11/13] packagegroup-go-sdk-target: add go-runtime-staticdev Matt Madison
2018-03-02 20:33 ` [PATCH v4 12/13] go-runtime: remove unneeded nativesdk override, rename variable Matt Madison
2018-03-02 20:33 ` [PATCH v4 13/13] go-cross-canadian: remove verbosity setting from GO_LDFLAGS Matt Madison
2018-03-03 16:40 ` [PATCH v4 00/13] go1.10 update and misc improvements Khem Raj
2018-03-03 17:44 ` Matt Madison
2018-03-03 19:59 ` Khem Raj
2018-03-03 22:45 ` Otavio Salvador
2018-03-04 2:28 ` Khem Raj
2018-03-04 20:46 ` Otavio Salvador
2018-03-04 21:10 ` Matt Madison
2018-03-05 11:22 ` Burton, Ross
2018-03-03 16:53 ` Richard Purdie
2018-03-03 17:23 ` Matt Madison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302203314.32737-5-matt@madison.systems \
--to=matt@madison.systems \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox