Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 13/42] kmod: refresh patches
Date: Thu,  8 Mar 2018 20:17:35 +0200	[thread overview]
Message-ID: <20180308181804.31261-13-alexander.kanavin@linux.intel.com> (raw)
In-Reply-To: <20180308181804.31261-1-alexander.kanavin@linux.intel.com>

From: Ross Burton <ross.burton@intel.com>

The patch tool will apply patches by default with "fuzz", which is where if the
hunk context isn't present but what is there is close enough, it will force the
patch in.

Whilst this is useful when there's just whitespace changes, when applied to
source it is possible for a patch applied with fuzz to produce broken code which
still compiles (see #10450).  This is obviously bad.

We'd like to eventually have do_patch() rejecting any fuzz on these grounds. For
that to be realistic the existing patches with fuzz need to be rebased and
reviewed.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
---
 meta/recipes-kernel/kmod/kmod/avoid_parallel_tests.patch | 13 +++++--------
 meta/recipes-kernel/kmod/kmod/fix-O_CLOEXEC.patch        | 15 ++++++---------
 2 files changed, 11 insertions(+), 17 deletions(-)

diff --git a/meta/recipes-kernel/kmod/kmod/avoid_parallel_tests.patch b/meta/recipes-kernel/kmod/kmod/avoid_parallel_tests.patch
index feafcb9b7c6..5f45fce932e 100644
--- a/meta/recipes-kernel/kmod/kmod/avoid_parallel_tests.patch
+++ b/meta/recipes-kernel/kmod/kmod/avoid_parallel_tests.patch
@@ -11,10 +11,10 @@ Upstream-Status: Inappropriate (disable feature incompatible with ptest)
  configure.ac | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
-diff --git a/configure.ac b/configure.ac
-index eb0f9d1..a539968 100644
---- a/configure.ac
-+++ b/configure.ac
+Index: git/configure.ac
+===================================================================
+--- git.orig/configure.ac
++++ git/configure.ac
 @@ -14,7 +14,7 @@ AC_USE_SYSTEM_EXTENSIONS
  AC_SYS_LARGEFILE
  AC_PREFIX_DEFAULT([/usr])
@@ -23,7 +23,4 @@ index eb0f9d1..a539968 100644
 +AM_INIT_AUTOMAKE([check-news foreign 1.11 silent-rules tar-pax no-dist-gzip dist-xz subdir-objects color-tests serial-tests])
  AM_SILENT_RULES([yes])
  LT_INIT([disable-static pic-only])
- 
--- 
-1.9.1
-
+ DOLT
diff --git a/meta/recipes-kernel/kmod/kmod/fix-O_CLOEXEC.patch b/meta/recipes-kernel/kmod/kmod/fix-O_CLOEXEC.patch
index 8161d6128d3..5d9d40c387f 100644
--- a/meta/recipes-kernel/kmod/kmod/fix-O_CLOEXEC.patch
+++ b/meta/recipes-kernel/kmod/kmod/fix-O_CLOEXEC.patch
@@ -18,12 +18,12 @@ Upstream-Status: Pending
  libkmod/libkmod-internal.h |    4 ++++
  1 file changed, 4 insertions(+)
 
-diff --git a/libkmod/libkmod-internal.h b/libkmod/libkmod-internal.h
-index 0180124..100b40f 100644
---- a/libkmod/libkmod-internal.h
-+++ b/libkmod/libkmod-internal.h
-@@ -9,6 +9,10 @@
- #include "macro.h"
+Index: git/libkmod/libkmod-internal.h
+===================================================================
+--- git.orig/libkmod/libkmod-internal.h
++++ git/libkmod/libkmod-internal.h
+@@ -10,6 +10,10 @@
+ 
  #include "libkmod.h"
  
 +#ifndef O_CLOEXEC
@@ -33,6 +33,3 @@ index 0180124..100b40f 100644
  static _always_inline_ _printf_format_(2, 3) void
  	kmod_log_null(struct kmod_ctx *ctx, const char *format, ...) {}
  
--- 
-1.7.10.4
-
-- 
2.16.1



  parent reply	other threads:[~2018-03-08 18:25 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 18:17 [PATCH 01/42] expat: refresh patches Alexander Kanavin
2018-03-08 18:17 ` [PATCH 02/42] grub: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 03/42] shared-mime-info: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 04/42] serf: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 05/42] nspr: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 06/42] libical: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 07/42] gmp: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 08/42] gnutls: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 09/42] libffi: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 10/42] libksba: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 11/42] libtiff: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 12/42] gstreamer: " Alexander Kanavin
2018-03-08 18:17 ` Alexander Kanavin [this message]
2018-03-08 18:17 ` [PATCH 14/42] dtc: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 15/42] lttng: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 16/42] wayland: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 17/42] clutter: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 18/42] xset: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 19/42] at: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 20/42] bash: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 21/42] ethtool: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 22/42] ghostscript: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 23/42] ghostscript: drop incorrectly applied patch Alexander Kanavin
2018-03-08 18:17 ` [PATCH 24/42] libidn: refresh patches Alexander Kanavin
2018-03-08 18:17 ` [PATCH 25/42] mdadm: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 26/42] pam: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 27/42] parted: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 28/42] tcp-wrappers: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 29/42] iptables: drop unnecessary patches Alexander Kanavin
2018-03-08 18:17 ` [PATCH 30/42] apt: refresh patches Alexander Kanavin
2018-03-08 18:17 ` [PATCH 31/42] automake: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 32/42] intltool: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 33/42] mtd: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 34/42] syslinux: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 35/42] ppp: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 36/42] util-linux: " Alexander Kanavin
2018-03-08 18:17 ` [PATCH 37/42] zlib: " Alexander Kanavin
2018-03-08 18:18 ` [PATCH 38/42] irda-utils: " Alexander Kanavin
2018-03-08 18:18 ` [PATCH 39/42] python-numpy: update to 1.14.1 Alexander Kanavin
2018-03-08 18:18 ` [PATCH 40/42] python: refresh patches Alexander Kanavin
2018-03-08 18:18 ` [PATCH 41/42] perl: " Alexander Kanavin
2018-03-08 18:18 ` [PATCH 42/42] perl: remove perl-enable-gdbm.patch Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308181804.31261-13-alexander.kanavin@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox