From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by mail.openembedded.org (Postfix) with ESMTP id 95A1F78951 for ; Sat, 17 Mar 2018 11:26:09 +0000 (UTC) Received: by mail-wm0-f66.google.com with SMTP id h21so7481673wmd.1 for ; Sat, 17 Mar 2018 04:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JH1uPl51TcnqHCEj3r7mVV1yZEr4lVVOVc/tfDOqMOw=; b=ZY12KAQGbPQkcIVuwQCQnWicQZVQ+fbWuyJPzlHB02fjOtOdTkIgxp6dEvQ5eOML6k 2qCqBtoRIQyEqI5HXY3zyfuSHWS3xdzmWaZMkyFMxfkmTBO2B2zWx7A6WR7JsjV7p2G5 MHG8yxyhXOnPuxKCpERQCJ4QLPV9s9QbNMhz6q/iKV5RIR6oExAFLER7cdoKnKIDVOi+ 3jW4bb/revE/LFFyae4JI28VVQUE4dYxwIVL6zjOa8+UvQtUTBKs21AW4CuCToL1KWrY 3Odme009bgnE+I5831xAeNPKmcf3LxLIzkz6ZrjFY8lUNDqGysWES6Nmy7v3lu1DEfjc gAxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JH1uPl51TcnqHCEj3r7mVV1yZEr4lVVOVc/tfDOqMOw=; b=AGiST31vZUZu7yvSR28qJcKtPAyJB9RX3NCAGPkqP0otB1nLQ2QsYjzCGFWx41U5kj er3eOZdDHk8gN9OQSWvjAA896FFIbz0IdLaFf/UXaLmfzwL5U/5u+7wMpOD1NwTx/Bj3 QEtmdjwNNa8+7sy/GtaLXkB6p+Ek9RbaYqttyDybj9YiPz75bTc82wRw7VdoD0VyBVst OunzOHWpYjbfV+pMAQS6SqxvN5K3RaguORJZrbu+s/vEpzeo9jxM6VGZWyo2teyNnSjg aiSE6BRUo8Z0DYj7iwEK5cbC79BAL40sIbDJsioGan4e0P5xDX1DqlONu93T1n8VTxDI 5gwA== X-Gm-Message-State: AElRT7EfRq5xlQEJ8WtW+B3rZf6jNoLS31hX4RPBYcbfyOC02DuCOcBk ZIAVEs1xir04NM0U0VdJ8Mj2Ig== X-Google-Smtp-Source: AG47ELuUa9H6U50sSjoerVjhWOtR4QMJUGJEEY3DNJBK21cAXm85nVwyip6w+dy9NZH2jFf+9FfL5g== X-Received: by 10.28.71.204 with SMTP id m73mr3868762wmi.111.1521285970336; Sat, 17 Mar 2018 04:26:10 -0700 (PDT) Received: from localhost ([217.30.68.212]) by smtp.gmail.com with ESMTPSA id x82sm8038102wmg.7.2018.03.17.04.26.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Mar 2018 04:26:09 -0700 (PDT) From: Martin Jansa X-Google-Original-From: Martin Jansa To: openembedded-core@lists.openembedded.org Date: Sat, 17 Mar 2018 11:26:07 +0000 Message-Id: <20180317112607.28536-1-Martin.Jansa@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: References: Subject: [PATCHv3] iputils: add PACKAGECONFIG for libidn and disable it by default X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2018 11:26:10 -0000 * it got enabled by default, but without the dependency on libidn in: commit 5997981fa2c22609a88b8cbb595dbf7758b2f7c2 Author: Alexander Kanavin AuthorDate: Thu Feb 1 20:02:08 2018 +0200 Subject: iputils: update to 20161105 * https://github.com/iputils/iputils/blob/master/RELNOTES.old mentiones that IDN was enabled by default in: [s20160308] and surprisingly the same in [s20150815] but there are no release notes for s20151218 version we were using until now, don't know how it really relates to [s20150815]. * but there are some issues with libidn as described in: https://github.com/iputils/iputils/commit/f3a461603ef4fb7512ade3bdb73fe1824e294547 so disable it by default. * fails with: | In file included from ping_common.c:1:0: | ping.h:39:10: fatal error: idna.h: No such file or directory | #include | ^~~~~~~~ * Easiest way to reproduce this failure is to remove libidn from gnutls PACKAGECONFIG or to use gnutls which doesn't have libidn PACKAGECONFIG at all (like the one in meta-gplv2). * First it leads to following QA issue: http://errors.yoctoproject.org/Errors/Build/53212/ ERROR: iputils-s20161105-r0 do_package_qa: QA Issue: iputils-ping rdepends on libidn, but it isn't a build dependency, missing libidn in DEPENDS or PACKAGECONFIG? [build-deps] ERROR: iputils-s20161105-r0 do_package_qa: QA Issue: iputils-traceroute6 rdepends on libidn, but it isn't a build dependency, missing libidn in DEPENDS or PACKAGECONFIG? [build-deps] ERROR: iputils-s20161105-r0 do_package_qa: QA run found fatal errors. Please consider fixing them. ERROR: iputils-s20161105-r0 do_package_qa: Function failed: do_package_qa ERROR: Logfile of failure stored in: /OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/iputils/s20161105-r0/temp/log.do_package_qa.7627 ERROR: Task (/OE/build/oe-core/openembedded-core/meta/recipes-extended/iputils/iputils_s20161105.bb:do_package_qa) failed with exit code '1' * But if you cleansstate iputils as well (after removing libidn from gnutls PACKAGECONFIG) to empty iputils RSS, then you get the error about missing idna.h: http://errors.yoctoproject.org/Errors/Build/53213/ * Adding the libidn dependency explicitly in iputils recipe fixes the issue. Signed-off-by: Martin Jansa --- meta/recipes-extended/iputils/iputils_s20161105.bb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meta/recipes-extended/iputils/iputils_s20161105.bb b/meta/recipes-extended/iputils/iputils_s20161105.bb index ad7dbc4d4a..0125739b03 100644 --- a/meta/recipes-extended/iputils/iputils_s20161105.bb +++ b/meta/recipes-extended/iputils/iputils_s20161105.bb @@ -23,8 +23,11 @@ UPSTREAM_CHECK_GITTAGREGEX = "(?Ps\d+)" EXTRA_OEMAKE = "-e MAKEFLAGS=" +PACKAGECONFIG ?= "" +PACKAGECONFIG[libidn] = "USE_IDN=yes,USE_IDN=no,libidn" + do_compile () { - oe_runmake 'CC=${CC} -D_GNU_SOURCE' VPATH="${STAGING_LIBDIR}:${STAGING_DIR_HOST}/${base_libdir}" all + oe_runmake 'CC=${CC} -D_GNU_SOURCE' VPATH="${STAGING_LIBDIR}:${STAGING_DIR_HOST}/${base_libdir}" ${PACKAGECONFIG_CONFARGS} all } do_install () { -- 2.15.1