Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] iputils: change default PACKAGECONFIG to disable libidn
Date: Tue, 20 Mar 2018 12:08:49 +0000	[thread overview]
Message-ID: <20180320120849.586-1-Martin.Jansa@gmail.com> (raw)
In-Reply-To: <CAJTo0LayEiw3bpXB7a-mKiGbi3uOJhFhYt=+4aV84dTSuVoJ3w@mail.gmail.com>

* wrong revision of this patch, where the commit message didn't match
  with the default PACKAGECONFIG value, was merged to master, update
  it to avoid confusion

* it got enabled by default, but without the dependency on libidn in:
  commit 5997981fa2c22609a88b8cbb595dbf7758b2f7c2
  Author: Alexander Kanavin <alexander.kanavin@linux.intel.com>
  AuthorDate: Thu Feb 1 20:02:08 2018 +0200
  Subject: iputils: update to 20161105

* https://github.com/iputils/iputils/blob/master/RELNOTES.old
  mentiones that IDN was enabled by default in:
  [s20160308] and surprisingly the same in [s20150815]
  but there are no release notes for s20151218 version we were using until
  now, don't know how it really relates to [s20150815].

* but there are some issues with libidn as described in:
  https://github.com/iputils/iputils/commit/f3a461603ef4fb7512ade3bdb73fe1824e294547
  so disable it by default.

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-extended/iputils/iputils_s20161105.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/iputils/iputils_s20161105.bb b/meta/recipes-extended/iputils/iputils_s20161105.bb
index dda891c7f7..0125739b03 100644
--- a/meta/recipes-extended/iputils/iputils_s20161105.bb
+++ b/meta/recipes-extended/iputils/iputils_s20161105.bb
@@ -23,7 +23,7 @@ UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>s\d+)"
 
 EXTRA_OEMAKE = "-e MAKEFLAGS="
 
-PACKAGECONFIG ?= "libidn"
+PACKAGECONFIG ?= ""
 PACKAGECONFIG[libidn] = "USE_IDN=yes,USE_IDN=no,libidn"
 
 do_compile () {
-- 
2.15.1



      reply	other threads:[~2018-03-20 12:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <151791522137.12584.390331907954611211@git.openembedded.org>
     [not found] ` <20180206110703.83BD6234808@git.openembedded.org>
2018-02-06 22:03   ` [oe-commits] [openembedded-core] 57/62: iputils: update to 20161105 Martin Jansa
2018-02-06 22:41     ` Martin Jansa
2018-02-06 22:44       ` [PATCH] iputils: add libidn dependency Martin Jansa
2018-02-07  7:40         ` Khem Raj
2018-03-17 11:21           ` [PATCHv2] iputils: add PACKAGECONFIG for libidn and disable it by default Martin Jansa
2018-03-17 11:26           ` [PATCHv3] " Martin Jansa
2018-03-19 23:32             ` Andre McCurdy
2018-03-20 10:19               ` Martin Jansa
2018-03-20 11:12                 ` Burton, Ross
2018-03-20 12:08                   ` Martin Jansa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180320120849.586-1-Martin.Jansa@gmail.com \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox