From: Seebs <seebs@seebs.net>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] pseudo: use latest SRCREV
Date: Fri, 20 Apr 2018 07:07:40 -0500 [thread overview]
Message-ID: <20180420070740.45cb22b9@seebsdell> (raw)
In-Reply-To: <20180420082526.24648-1-Martin.Jansa@gmail.com>
On Fri, 20 Apr 2018 08:25:26 +0000
Martin Jansa <martin.jansa@gmail.com> wrote:
> * the pseudo.log is significantly shorter with this revision
There's also an actually fairly significant bug fix in here. At one
point, long ago, I made a function that expands paths, and takes a flag
argument which may or may not be AT_SYMLINK_NOFOLLOW.
And then for openat(2), it gets called with "flags", whatever those are.
And it turns out that this means that any flag value other than 0
caused pseudo not to follow a terminal symlink when expanding path,
which caused a number of very strange problems. And mostly those got
corrected, but this should reduce errors.
The change to drop the usually-harmless "path mismatch [%d links]"
messages for N>1 is purely cosmetic, but we're talking about 4MB of
cosmetic messages in a glibc locale build...
-s
prev parent reply other threads:[~2018-04-20 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 8:25 [PATCH] pseudo: use latest SRCREV Martin Jansa
2018-04-20 12:07 ` Seebs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420070740.45cb22b9@seebsdell \
--to=seebs@seebs.net \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox