From: Joshua Watt <jpewhacker@gmail.com>
To: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: [sumo][PATCH] Revert "icecc.bbclass: Improve error reporting"
Date: Fri, 20 Apr 2018 08:54:06 -0500 [thread overview]
Message-ID: <20180420135406.28410-1-JPEWhacker@gmail.com> (raw)
This reverts commit b28114cf1e58643bd233bc0c83d6d8138952b7ac.
The "-E" option for flock is not ubiquitously supported, so don't use
it.
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
meta/classes/icecc.bbclass | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
index 73eba7a6a96..0ca8de86c24 100644
--- a/meta/classes/icecc.bbclass
+++ b/meta/classes/icecc.bbclass
@@ -366,20 +366,14 @@ set_icecc_env() {
# the ICECC_VERSION generation step must be locked by a mutex
# in order to prevent race conditions
- exit_code=0
- flock -n -E 10 "${ICECC_VERSION}.lock" \
- ${ICECC_ENV_EXEC} ${ICECC_ENV_DEBUG} "${ICECC_CC}" "${ICECC_CXX}" "${ICECC_AS}" "${ICECC_VERSION}" || exit_code=$?
- if [ "$exit_code" -eq 0 ]; then
- touch "${ICECC_VERSION}.done"
- elif [ "$exit_code" -eq "10" ]; then
- if [ ! wait_for_file "${ICECC_VERSION}.done" 30 ]; then
- # locking failed so wait for ${ICECC_VERSION}.done to appear
- bbwarn "Timeout waiting for ${ICECC_VERSION}.done"
- return
- fi
- else
- bbwarn "Could not create icecc environment: $exit_code"
+ if flock -n "${ICECC_VERSION}.lock" \
+ ${ICECC_ENV_EXEC} ${ICECC_ENV_DEBUG} "${ICECC_CC}" "${ICECC_CXX}" "${ICECC_AS}" "${ICECC_VERSION}"
+ then
touch "${ICECC_VERSION}.done"
+ elif [ ! wait_for_file "${ICECC_VERSION}.done" 30 ]
+ then
+ # locking failed so wait for ${ICECC_VERSION}.done to appear
+ bbwarn "Timeout waiting for ${ICECC_VERSION}.done"
return
fi
fi
--
2.14.3
reply other threads:[~2018-04-20 13:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420135406.28410-1-JPEWhacker@gmail.com \
--to=jpewhacker@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox