From: Khem Raj <raj.khem@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 6/6] llvm: Fix [compile-host-path] QA issue
Date: Fri, 20 Apr 2018 09:33:54 -0700 [thread overview]
Message-ID: <20180420163354.12065-6-raj.khem@gmail.com> (raw)
In-Reply-To: <20180420163354.12065-1-raj.khem@gmail.com>
Its trying to build NATIVE llvm-config which is
already built with llvm-native so we do not need
to rebuild it
Drop setting NINJA_STATUS explicitly, its no longer
needed, on the contrary it hinders the task status
update
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
Changes since v1:
- Rebased
...able-generating-a-native-llvm-config.patch | 41 +++++++++++++++++++
meta/recipes-devtools/llvm/llvm_git.bb | 7 ++--
2 files changed, 45 insertions(+), 3 deletions(-)
create mode 100644 meta/recipes-devtools/llvm/llvm/0001-Disable-generating-a-native-llvm-config.patch
diff --git a/meta/recipes-devtools/llvm/llvm/0001-Disable-generating-a-native-llvm-config.patch b/meta/recipes-devtools/llvm/llvm/0001-Disable-generating-a-native-llvm-config.patch
new file mode 100644
index 0000000000..2809e4c594
--- /dev/null
+++ b/meta/recipes-devtools/llvm/llvm/0001-Disable-generating-a-native-llvm-config.patch
@@ -0,0 +1,41 @@
+From 7f7743ce233fcd735ec580c75270413493658aa6 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Thu, 19 Apr 2018 18:08:31 -0700
+Subject: [PATCH] Disable generating a native llvm-config
+
+OpenEmbedded already builds this as part of llvm-native
+
+Upstream-Status: Inappropriate [OE-Specific]
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ tools/llvm-config/CMakeLists.txt | 16 ----------------
+ 1 file changed, 16 deletions(-)
+
+diff --git a/tools/llvm-config/CMakeLists.txt b/tools/llvm-config/CMakeLists.txt
+index 25f99cec978..c45e9b642a8 100644
+--- a/tools/llvm-config/CMakeLists.txt
++++ b/tools/llvm-config/CMakeLists.txt
+@@ -63,19 +63,3 @@ endif()
+
+ # Add the dependency on the generation step.
+ add_file_dependencies(${CMAKE_CURRENT_SOURCE_DIR}/llvm-config.cpp ${BUILDVARIABLES_OBJPATH})
+-
+-if(CMAKE_CROSSCOMPILING)
+- set(${project}_LLVM_CONFIG_EXE "${LLVM_NATIVE_BUILD}/bin/llvm-config")
+- set(${project}_LLVM_CONFIG_EXE ${${project}_LLVM_CONFIG_EXE} PARENT_SCOPE)
+-
+- add_custom_command(OUTPUT "${${project}_LLVM_CONFIG_EXE}"
+- COMMAND ${CMAKE_COMMAND} --build . --target llvm-config --config $<CONFIGURATION>
+- DEPENDS ${LLVM_NATIVE_BUILD}/CMakeCache.txt
+- WORKING_DIRECTORY ${LLVM_NATIVE_BUILD}
+- COMMENT "Building native llvm-config..."
+- USES_TERMINAL)
+- add_custom_target(${project}NativeLLVMConfig DEPENDS ${${project}_LLVM_CONFIG_EXE})
+- add_dependencies(${project}NativeLLVMConfig CONFIGURE_LLVM_NATIVE)
+-
+- add_dependencies(llvm-config ${project}NativeLLVMConfig)
+-endif(CMAKE_CROSSCOMPILING)
+--
+2.17.0
+
diff --git a/meta/recipes-devtools/llvm/llvm_git.bb b/meta/recipes-devtools/llvm/llvm_git.bb
index 77c095d9a3..cb3bba6fab 100644
--- a/meta/recipes-devtools/llvm/llvm_git.bb
+++ b/meta/recipes-devtools/llvm/llvm_git.bb
@@ -26,6 +26,7 @@ PATCH_VERSION = "0"
SRC_URI = "git://github.com/llvm-mirror/llvm.git;branch=${BRANCH};protocol=http \
file://0001-llvm-TargetLibraryInfo-Undefine-libc-functions-if-th.patch \
file://0002-llvm-allow-env-override-of-exe-path.patch \
+ file://0001-Disable-generating-a-native-llvm-config.patch \
"
UPSTREAM_CHECK_COMMITS = "1"
S = "${WORKDIR}/git"
@@ -85,15 +86,15 @@ do_configure_prepend() {
}
do_compile() {
- NINJA_STATUS="[%p] " ninja -v ${PARALLEL_MAKE}
+ ninja -v ${PARALLEL_MAKE}
}
do_compile_class-native() {
- NINJA_STATUS="[%p] " ninja -v ${PARALLEL_MAKE} llvm-config llvm-tblgen
+ ninja -v ${PARALLEL_MAKE} llvm-config llvm-tblgen
}
do_install() {
- NINJA_STATUS="[%p] " DESTDIR=${LLVM_INSTALL_DIR} ninja -v install
+ DESTDIR=${LLVM_INSTALL_DIR} ninja -v install
install -D -m 0755 ${B}/bin/llvm-config ${D}${libdir}/${LLVM_DIR}/llvm-config
install -d ${D}${bindir}/${LLVM_DIR}
--
2.17.0
next prev parent reply other threads:[~2018-04-20 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 16:33 [PATCH V2 1/6] libssp-nonshared: Add recipe Khem Raj
2018-04-20 16:33 ` [PATCH V2 2/6] musl: Depend on libssp-nonshared Khem Raj
2018-04-20 16:33 ` [PATCH v3 3/6] gcc-runtime: Disable gcc version of libssp Khem Raj
2018-04-20 16:33 ` [PATCH V2 4/6] libunwind: Drop adding libssp to linker flags Khem Raj
2018-04-20 16:33 ` [PATCH V3 5/6] musl: Upgrade to latest Khem Raj
2018-04-20 16:33 ` Khem Raj [this message]
2018-04-30 13:08 ` [PATCH V2 1/6] libssp-nonshared: Add recipe Burton, Ross
2018-04-30 14:17 ` Khem Raj
2018-04-30 15:05 ` Burton, Ross
2018-04-30 15:21 ` Burton, Ross
2018-04-30 15:25 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420163354.12065-6-raj.khem@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox