Openembedded Core Discussions
 help / color / mirror / Atom feed
From: sarah.marsh.engineer@gmail.com
To: openembedded-core@lists.openembedded.org
Cc: Sarah Marsh <sarah.marsh.engineer@gmail.com>
Subject: [PATCH] `NameError` is currently thrown in create_npm.py
Date: Wed, 25 Apr 2018 19:11:25 -0500	[thread overview]
Message-ID: <20180426001125.28610-1-sarah.marsh.engineer@gmail.com> (raw)

From: Sarah Marsh <sarah.marsh.engineer@gmail.com>

This happens if an optional npm dependency does not support Linux.

Signed-off-by: Sarah Marsh <sarah.marsh.engineer@gmail.com>
---
 scripts/lib/recipetool/create_npm.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/lib/recipetool/create_npm.py b/scripts/lib/recipetool/create_npm.py
index fb57e705f2..bb42a5ca5c 100644
--- a/scripts/lib/recipetool/create_npm.py
+++ b/scripts/lib/recipetool/create_npm.py
@@ -320,6 +320,7 @@ class NpmRecipeHandler(RecipeHandler):
                     blacklist = True
                     break
             if (not blacklist and 'linux' not in pkg_os) or '!linux' in pkg_os:
+                pkg = pdata.get('name', 'Unnamed package')
                 logger.debug(2, "Skipping %s since it's incompatible with Linux" % pkg)
                 return False
         return True
-- 
2.14.3 (Apple Git-98)



             reply	other threads:[~2018-04-26  0:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26  0:11 sarah.marsh.engineer [this message]
2018-04-26  0:32 ` ✗ patchtest: failure for `NameError` is currently thrown in create_npm.py Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426001125.28610-1-sarah.marsh.engineer@gmail.com \
    --to=sarah.marsh.engineer@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox