From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by mail.openembedded.org (Postfix) with ESMTP id 51C927539A; Thu, 10 May 2018 23:32:32 +0000 (UTC) Received: by mail-wm0-f68.google.com with SMTP id f8-v6so56021wmc.4; Thu, 10 May 2018 16:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SUv6gfzlZXLw7SNUV+S3EK7CICyIgMbxGSxtkAb7/no=; b=U9JT4EjrAjLhj4BRvuDIfYzHwfM9B6l6orbe98LA2lXxKpW5/aXIVyDQpNRN9htf+C gl8nigYOs3IaMgpUg9TiU4aXScCgXs5H63DfOtKK3g+tmq7JxdNE5DoRUuHvKisu+1Ys DZh5YUA3Xy2Er4eIs3lXOwVP/d8fKt+51g9yJj5vY16jzLK+YhBb9KoNlATahDM+ertR HGZhaeQYmkqMs4rRUA6LIafSPV/6ID/Bse72WS9ivv91O3mqxxRHsOLovT/OM54Ch03Y 3FXZCJ4xh9UfbtGhrFueIbn3RUS6e5D6UJap9ijKQlnPCMaHvIlcmVpVscXGucN/CwOv YR8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SUv6gfzlZXLw7SNUV+S3EK7CICyIgMbxGSxtkAb7/no=; b=ZhJ1A6ysX7QNzW3fa17JfcEIc7PDlgpkSynJWJaHoOKFdF2DFPV2XRe7r88zhhZ4sm kqRnl51fTdCgFsBzzIYW0DGp8EJDZqYcNzR1nnZtr1OoJ1tgrYp2ob4WCDWTVE3ze4mm GLK6rqkX87apPxXyV3WFgRR0oO49RzCfRA6ecJfQVbwHIej8rThOd9KtoPgNCSnbPOSw 6kWf1BoGQQox+5hPe71Y//mRnadLGYIpvgmefvWyo12gJsKmly/lcPb3uZIt3UwC88Ef aM3UcG/BVZd/dhSgIaeUojxbnPkrRPyyrCrqy91uiQ1CNQ2DVjSWoKxD7bgRJ3ISFiOS Cb4A== X-Gm-Message-State: ALKqPwfcmCvTae9N6Uo9OIiRHg7atKs1Ht6Yj2PQMt6j0IHj4s91s7zO hYckQ9RlAZbvW6fC7QPOdl0= X-Google-Smtp-Source: AB8JxZoGPBWg/PbdoZttyNh890XRNFdwUl9wY6GXa9cjBC8sdQNe7e2G7QJACy4x70Yh//GeHjD68w== X-Received: by 2002:a1c:d546:: with SMTP id m67-v6mr515417wmg.117.1525995153793; Thu, 10 May 2018 16:32:33 -0700 (PDT) Received: from localhost ([217.30.68.212]) by smtp.gmail.com with ESMTPSA id o53-v6sm3634166wrc.96.2018.05.10.16.32.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 May 2018 16:32:32 -0700 (PDT) From: Martin Jansa X-Google-Original-From: Martin Jansa Date: Fri, 11 May 2018 01:32:33 +0200 To: Andre McCurdy Message-ID: <20180510233233.GF1954@jama> References: <8d962430-ac63-5e97-fd32-2c0464c62acb@gmail.com> <20180510191145.GA1954@jama> <20180510214325.GC1954@jama> <20180510220735.GD1954@jama> <20180510225017.GE1954@jama> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Cc: Yocto Project , Patches and discussions about the oe-core layer , openembedded-devel Subject: Re: [RFT] GCC 8.1 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 23:32:33 -0000 X-Groupsio-MsgNum: 111254 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ChQOR20MqfxkMJg9" Content-Disposition: inline --ChQOR20MqfxkMJg9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 10, 2018 at 04:11:00PM -0700, Andre McCurdy wrote: > On Thu, May 10, 2018 at 3:50 PM, Martin Jansa wr= ote: > > On Thu, May 10, 2018 at 03:40:53PM -0700, Andre McCurdy wrote: > >> On Thu, May 10, 2018 at 3:38 PM, Martin Jansa = wrote: > >> > see > >> > http://lists.openembedded.org/pipermail/openembedded-core/2018-May/1= 50654.html > >> > >> Removing -fno-omit-frame-pointer isn't the same as adding > >> -fomit-frame-pointer. Frame pointers may get enabled depending on the > >> optimisation level etc (ie not only by -fno-omit-frame-pointer). > > > > Should I send v2 adding -fomit-frame-pointer instead of removing > > -fno-omit-frame-pointer? > > > > The v1 fixes the issue for me with default config + DEBUG_BUILD. >=20 > The v1 patch isn't wrong, it's just incomplete (the problem could come > back if someone changes optimisation level or switches gcc to clang, > etc). >=20 > My choice would be a v2 patch which adds -fomit-frame-pointer to > CFLAGS unconditionally for all ARM builds when Thumb is enabled. That > should fix the problem for all optimisation levels etc and avoids > building the main strace binary differently depending on whether or > not ptest is enabled. Only for thumb? makes me a bit sad that thumb override was dropped by you in 351443d71eb246a946b41f12b54d57b36fe1574e --=20 Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com --ChQOR20MqfxkMJg9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQRU+ejDffEzV2Je2oc3VSO3ZXaAHAUCWvTWkAAKCRA3VSO3ZXaA HC08AKCCfUOfJAkV1zpQiqU+6nzj611K2QCfd+7YnuLZzHs/BFtbN3kq4P7ewj0= =C5GB -----END PGP SIGNATURE----- --ChQOR20MqfxkMJg9--