From: Andrej Valek <andrej.valek@siemens.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v6 1/3] openssl-1.1: fix c_rehash perl errors
Date: Tue, 17 Jul 2018 11:10:33 +0200 [thread overview]
Message-ID: <20180717091035.26461-2-andrej.valek@siemens.com> (raw)
In-Reply-To: <20180717091035.26461-1-andrej.valek@siemens.com>
In-Reply-To: <20180709125657.13192-1-andrej.valek@siemens.com>
Patch original c_rehash script with Debian patch instead
of overriding it with own version.
Error output from c_reshah without patching:
Unknown regexp modifier "/b" at ./c_rehash line 15, at end of line
Unknown regexp modifier "/W" at ./c_rehash line 28, at end of line
Unknown regexp modifier "/3" at ./c_rehash line 28, at end of line
Unknown regexp modifier "/2" at ./c_rehash line 28, at end of line
No such class installdir at ./c_rehash line 63, near "Prefix our
installdir"
(Might be a runaway multi-line // string starting on line 28)
syntax error at ./c_rehash line 63, near "Prefix our installdir"
Can't redeclare "my" in "my" at ./c_rehash line 68, near ""
Execution of ./c_rehash aborted due to compilation errors.
Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
Signed-off-by: Marko Peter <peter.marko@siemens.com>
---
...-dofile.pl-only-quote-stuff-that-actually.patch | 29 ++++++++++++++++++++++
.../recipes-connectivity/openssl/openssl_1.1.0h.bb | 1 +
2 files changed, 30 insertions(+)
create mode 100644 meta/recipes-connectivity/openssl/openssl/0002-Revert-util-dofile.pl-only-quote-stuff-that-actually.patch
diff --git a/meta/recipes-connectivity/openssl/openssl/0002-Revert-util-dofile.pl-only-quote-stuff-that-actually.patch b/meta/recipes-connectivity/openssl/openssl/0002-Revert-util-dofile.pl-only-quote-stuff-that-actually.patch
new file mode 100644
index 0000000000..81a9b2d060
--- /dev/null
+++ b/meta/recipes-connectivity/openssl/openssl/0002-Revert-util-dofile.pl-only-quote-stuff-that-actually.patch
@@ -0,0 +1,29 @@
+openssl-1.1.0h: Fix c_rehash perl errors
+
+[No upstream tracking] -- https://github.com/openssl/openssl/issues/5772
+
+dofile.pl: Revert only quote stuff that actually needs quoting
+
+This wasn't a good solution, too many things depend on the quotes being
+there consistently.
+
+Upstream-Status: Backport [https://github.com/openssl/openssl/commit/00701e5ea84861b74d9d624f21a6b3fcb12e8acd]
+bug: 5772
+Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
+
+diff --git a/util/dofile.pl b/util/dofile.pl
+index 955224df7d..b0e20681dd 100644
+--- a/util/dofile.pl
++++ b/util/dofile.pl
+@@ -99,9 +99,9 @@ package main;
+ # This adds quotes (") around the given string, and escapes any $, @, \,
+ # " and ' by prepending a \ to them.
+ sub quotify1 {
+- my $s = my $orig = shift @_;
++ my $s = shift @_;
+ $s =~ s/([\$\@\\"'])/\\$1/g;
+- $s ne $orig || $s =~ /\s/ ? '"'.$s.'"' : $s;
++ '"'.$s.'"';
+ }
+
+ # quotify_l LIST
diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb b/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb
index 8d445e4655..c5de085521 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb
@@ -12,6 +12,7 @@ SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
file://run-ptest \
file://openssl-c_rehash.sh \
file://0001-Take-linking-flags-from-LDFLAGS-env-var.patch \
+ file://0002-Revert-util-dofile.pl-only-quote-stuff-that-actually.patch \
"
SRC_URI_append_class-nativesdk = " \
--
2.11.0
next prev parent reply other threads:[~2018-07-17 9:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 12:56 [PATCH resend 0/3] Openssl 1.1 upgrading Andrej Valek
2018-07-09 12:56 ` [PATCH resend 1/3] openssl-1.1: fix c_rehash perl errors Andrej Valek
2018-07-09 21:53 ` Richard Purdie
2018-07-09 12:56 ` [PATCH resend 2/3] openssl-1.1: rework packaging Andrej Valek
2018-07-09 12:56 ` [PATCH resend 3/3] openssl-1.1: /etc/ssl location compatibility Andrej Valek
2018-07-10 7:46 ` [PATCH v5 0/3] Openssl 1.1 upgrading Andrej Valek
2018-07-10 7:46 ` [PATCH v5 1/3] openssl-1.1: fix c_rehash perl errors Andrej Valek
2018-07-10 7:46 ` [PATCH v5 2/3] openssl-1.1: rework packaging Andrej Valek
2018-07-10 7:46 ` [PATCH v5 3/3] openssl-1.1: /etc/ssl location compatibility Andrej Valek
2018-07-17 9:10 ` [PATCH v6 0/3] Openssl 1.1 upgrading Andrej Valek
2018-07-30 11:12 ` Andrej Valek
2018-07-17 9:10 ` Andrej Valek [this message]
2018-07-17 9:10 ` [PATCH v6 2/3] openssl-1.1: rework packaging Andrej Valek
2018-08-16 19:34 ` Andre McCurdy
2018-08-17 5:05 ` Andre McCurdy
2018-07-17 9:10 ` [PATCH v6 3/3] openssl-1.1: /etc/ssl location compatibility Andrej Valek
2018-08-16 23:38 ` Andre McCurdy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717091035.26461-2-andrej.valek@siemens.com \
--to=andrej.valek@siemens.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox