From: Tom Rini <trini@konsulko.com>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] wic: allow bitbake variables in kickstarter files
Date: Thu, 19 Jul 2018 08:51:58 -0400 [thread overview]
Message-ID: <20180719125158.GH4609@bill-the-cat> (raw)
In-Reply-To: <20180322134413.8079-1-rasmus.villemoes@prevas.dk>
On Thu, Mar 22, 2018 at 02:44:13PM +0100, Rasmus Villemoes wrote:
> image_types_wic.bbclass has a mechanism for doing variable substitution
> on .wks files by simply letting the input file be called
> .wks.in. However, that doesn't allow using variables in files included
> via the include directive.
>
> This adds (somewhat naive) support for variable substitution in all
> files parsed by wic. The user should add all required variables to
> WICVARS to get them exported appropriately.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
This seems quite useful and I like the idea. I don't know the wic
internals well enough to "Reviewed-by" this myself, sorry.
--
Tom
prev parent reply other threads:[~2018-07-19 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 13:44 [PATCH] wic: allow bitbake variables in kickstarter files Rasmus Villemoes
2018-04-10 12:11 ` Rasmus Villemoes
2018-04-30 20:19 ` Rasmus Villemoes
2018-06-21 19:16 ` Martin Hundebøll
2018-07-03 12:54 ` [PATCH resend] " Rasmus Villemoes
2018-07-17 8:14 ` Rasmus Villemoes
2018-07-19 7:13 ` Sean Nyekjær
2018-12-29 0:06 ` [PATCH resend^2] " Rasmus Villemoes
2019-01-09 6:57 ` Rasmus Villemoes
2019-01-13 11:18 ` Rasmus Villemoes
2018-07-19 12:51 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719125158.GH4609@bill-the-cat \
--to=trini@konsulko.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=rasmus.villemoes@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox