From: <Mikko.Rapeli@bmw.de>
To: <peter.kjellerstedt@axis.com>
Cc: Michael.Ho@bmw.de, Thomas.Witt@bmw.de,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] openssl10: remove extra slash from libdir path
Date: Mon, 24 Sep 2018 07:03:38 +0000 [thread overview]
Message-ID: <20180924070338.GB9430@hiutale> (raw)
In-Reply-To: <cff1f5c8f79f46dfa369c102d57d13b4@XBOX02.axis.com>
On Fri, Sep 21, 2018 at 04:41:50PM +0000, Peter Kjellerstedt wrote:
> > diff --git a/meta/recipes-connectivity/openssl/openssl10_1.0.2p.bb
> > b/meta/recipes-connectivity/openssl/openssl10_1.0.2p.bb
> > index b7297fc..f09782c 100644
> > --- a/meta/recipes-connectivity/openssl/openssl10_1.0.2p.bb
> > +++ b/meta/recipes-connectivity/openssl/openssl10_1.0.2p.bb
> > @@ -191,7 +191,7 @@ do_configure () {
> > if [ "x$useprefix" = "x" ]; then
> > useprefix=/
> > fi
> > - libdirleaf="$(echo ${libdir} | sed s:$useprefix::)"
> > + libdirleaf="$( basename "${libdir}" )"
>
> You are making assumptions about the value of ${libdir} here.
> May I suggest the following instead (just in case someone has
> defined libdir as ${prefix}/foo/lib):
>
> libdirleaf="$(echo ${libdir} | sed s:^$useprefix/*::)"
Ok, sending v2 with this.
-Mikko
prev parent reply other threads:[~2018-09-24 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 16:01 [PATCH] openssl10: remove extra slash from libdir path Mikko Rapeli
2018-09-21 16:41 ` Peter Kjellerstedt
2018-09-24 7:03 ` Mikko.Rapeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924070338.GB9430@hiutale \
--to=mikko.rapeli@bmw.de \
--cc=Michael.Ho@bmw.de \
--cc=Thomas.Witt@bmw.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox