From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by mail.openembedded.org (Postfix) with ESMTP id 6EBAE6D9AB for ; Wed, 16 Jan 2019 10:12:41 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id y7so2264586ybg.13 for ; Wed, 16 Jan 2019 02:12:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=6t3blkSEMyNpDmW+NXopQ4JdrTMetSEaUfloe1nb/yc=; b=O5j9Ke+rBfHpq0YBjUWnbxYjVRYtSzWvKrcvttkPg+HHgqL1eLSRvE0dHLK2ZMhoZ3 stznUo3AXBThPgD3exQ0apnI/1/BfSXqyR/nSwR2mbIqGUMnhz0NN8X+i+v4+3KAfS9z 1k33JRQ2FrzlizDEAwO4eRl6pxCoB9yoKISaS5E/XhrvRG6Dj6Y/OD0nDGp9DYkbCmkD quHLe/WFPJYhxMm85SO4sz34xVw+uNKLZiyzKdSq4spQlAUOBNwIjSdVo5is+v1lFK91 jML78ClkiXh9M2L+Q3d7B4ogonh9ztA2DTPpaNBmSSAynK0awYiPDTB+zd98cEfaVlDc g0oA== X-Gm-Message-State: AJcUukf3ImD43R8P4oBlwnXY5Kjfh4NmLErfgTz1ABcGgGsiqR69GPv0 YABtwJBYgVnvxqggJWv2PbVsiGgm X-Google-Smtp-Source: ALg8bN4tP2ozR7bcolFXMzwAnRcxTm0U8eeJcvp+Pz1IuH9o+88KzJ+TSr9Xo30L2tKvvfSrulUPjw== X-Received: by 2002:a25:680a:: with SMTP id d10mr6718831ybc.341.1547633562216; Wed, 16 Jan 2019 02:12:42 -0800 (PST) Received: from tfsielt31850.garage.tyco.com ([77.107.218.170]) by smtp.gmail.com with ESMTPSA id n16sm2652733ywn.31.2019.01.16.02.12.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 02:12:41 -0800 (PST) From: =?UTF-8?q?Andr=C3=A9=20Draszik?= To: openembedded-core@lists.openembedded.org Date: Wed, 16 Jan 2019 10:12:38 +0000 Message-Id: <20190116101238.22173-1-git@andred.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [PATCH] classes/compress_doc: add missing import subprocess X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 10:12:41 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: André Draszik Enabling compress_doc gives the following stack trace: File: 'exec_python_func() autogenerated', lineno: 2, function: 0001: *** 0002:package_do_compress_doc(d) 0003: File: '/scratch/yocto/swupd.bb/poky/meta/classes/compress_doc.bbclass', lineno: 50, function: package_do_compress_doc 0046: mandir = os.path.abspath(dvar + os.sep + d.getVar("mandir")) 0047: if os.path.exists(mandir): 0048: # Decompress doc files which format is not compress_mode 0049: decompress_doc(mandir, compress_mode, decompress_cmds) *** 0050: compress_doc(mandir, compress_mode, compress_cmds) 0051: 0052: infodir = os.path.abspath(dvar + os.sep + d.getVar("infodir")) 0053: if os.path.exists(infodir): 0054: # Decompress doc files which format is not compress_mode File: '/scratch/yocto/swupd.bb/poky/meta/classes/compress_doc.bbclass', lineno: 180, function: compress_doc 0176: _collect_hardlink(hardlink_dict, file) 0177: # Normal file 0178: elif os.path.isfile(file): 0179: cmd = "%s %s" % (compress_cmds[compress_mode], file) *** 0180: (retval, output) = subprocess.getstatusoutput(cmd) 0181: if retval: 0182: bb.warn("compress failed %s (cmd was %s)%s" % (retval, cmd, ":\n%s" % output if output else "")) 0183: continue 0184: bb.note('compress file %s' % file) Exception: NameError: name 'subprocess' is not defined Fix by adding the missing import in two places. Signed-off-by: André Draszik --- meta/classes/compress_doc.bbclass | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/classes/compress_doc.bbclass b/meta/classes/compress_doc.bbclass index 45bb8fff65..d6d11fad26 100644 --- a/meta/classes/compress_doc.bbclass +++ b/meta/classes/compress_doc.bbclass @@ -160,6 +160,7 @@ def _is_compress_doc(file, compress_format_list): return False, '' def compress_doc(topdir, compress_mode, compress_cmds): + import subprocess hardlink_dict = {} for root, dirs, files in os.walk(topdir): for f in files: @@ -187,6 +188,7 @@ def compress_doc(topdir, compress_mode, compress_cmds): # Decompress doc files which format is not compress_mode def decompress_doc(topdir, compress_mode, decompress_cmds): + import subprocess hardlink_dict = {} decompress = True for root, dirs, files in os.walk(topdir): -- 2.20.1