Re: [PATCH 3/4] packagegroup-core-base-utils: Introduce new base-utils packagegroup

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 4409 bytes --]

On Mon, Mar 04, 2019 at 10:44:00AM -0600, Mark Hatle wrote:
> On 3/1/19 4:26 PM, Tom Rini wrote:
> > This packagegroup is intended to provide all of the functionality found
> > in other VIRTUAL-RUNTIME_base-utils providers through full packages
> > rather than an all-on-one package.  Document how to make use of this
> > in local.conf.sample.extended.  Introduce VIRTUAL-RUNTIME-vim and
> > default this to vim-tiny to allow for a differently features vim to be
> > used instead.
> > 
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> >  meta/conf/local.conf.sample.extended               |  8 ++++
> >  .../packagegroups/packagegroup-core-base-utils.bb  | 49 ++++++++++++++++++++++
> >  2 files changed, 57 insertions(+)
> >  create mode 100644 meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
> > 
> > diff --git a/meta/conf/local.conf.sample.extended b/meta/conf/local.conf.sample.extended
> > index 8062e4c5721b..d00221893ad9 100644
> > --- a/meta/conf/local.conf.sample.extended
> > +++ b/meta/conf/local.conf.sample.extended
> > @@ -384,3 +384,11 @@
> >  #VIRTUAL-RUNTIME_login_manager = "shadow-base"
> >  #VIRTUAL-RUNTIME_init_manager = "systemd"
> >  #VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"
> > +
> > +#
> > +# Use a full set of packages instead of busybox for base utils
> > +#
> > +#PREFERRED_PROVIDER_base-utils = "packagegroup-core-base-utils"
> > +#VIRTUAL-RUNTIME_base-utils = "packagegroup-core-base-utils"
> > +#VIRTUAL-RUNTIME_base-utils-hwclock = "util-linux-hwclock"
> > +#VIRTUAL-RUNTIME_base-utils-syslog = "syslog"
> > diff --git a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
> > new file mode 100644
> > index 000000000000..061dade0bc03
> > --- /dev/null
> > +++ b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
> > @@ -0,0 +1,49 @@
> > +#
> > +# Copyright (C) 2019 Konsulko Group
> > +#
> > +
> > +SUMMARY = "Full-featured set of base utils"
> > +DESCRIPTION = "Package group bringing in packages needed to provide much of the base utils type functionality found in busybox"
> > +
> > +inherit packagegroup
> > +
> > +VIRTUAL-RUNTIME_vim ?= "vim-tiny"
> > +
> > +RDEPENDS_${PN} = "\
> > +    base-passwd \
> > +    bash \
> > +    bind-utils \
> > +    bzip2 \
> > +    coreutils \
> > +    cpio \
> > +    dhcp-client \
> > +    diffutils \
> > +    e2fsprogs \
> > +    ed \
> > +    file \
> > +    findutils \
> > +    gawk \
> > +    grep \
> > +    gzip \
> > +    inetutils \
> > +    iproute2 \
> > +    kmod \
> > +    less \
> > +    lzip \
> > +    ncurses-tools \
> > +    net-tools \
> > +    parted \
> > +    patch \
> > +    procps \
> > +    psmisc \
> > +    sed \
> > +    shadow-base \
> > +    tar \
> > +    time \
> > +    unzip \
> > +    util-linux \
> > +    ${VIRTUAL-RUNTIME_vim} \
> > +    wget \
> > +    which \
> > +    xz \
> > +    "
> > 
> 
> Sorry missed this earlier.  On note, we have a similar recipe in our local layer.
> 
> I figured you may want to look at it to determine if anything might be missing.
> 
> https://github.com/WindRiver-OpenSourceLabs/wrlinux/blob/master-wr/recipes-base/packagegroups/packagegroup-busybox-replacement.bb
> 
> The parts I see missing (when comparing them) are:
> 
> bc

I had this initially but bc isn't enabled in busybox (anymore?).

> debianutils-run-parts
> dhcp-server (likely not needed)
> dpkg-start-stop
> ifupdown

These fall into the category of "Oh, I need to try without systemd".
I'll put those in and give it a spin.

> kbd

This is in, but via a dep rather than explicit, so I'll list it.

> In some configurations we also add "fbset, netcat, and usleep" as well... but I
> think the reasonable approach is to match the default busybox configuration to
> whatever is in this list.

Ah fbset, going off on a quick tangent, I see 2.1 from 1999 is still the
latest and greatest.  Good times!  I'm not sure if we should move fbset
to oe-core however.  For netcat, we have netcat-openbsd in meta-oe which
is 'nc' and would match busybox saying CONFIG_NC=y and CONFIG_NETCAT=n.
For usleep, real sleep (and busybox sleep when configured) supports
decimals so I would be inclined to say sleep is good enough.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]