Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Jonathan Rajotte-Julien <jonathan.rajotte-julien@efficios.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] lttng: Enable on musl and riscv
Date: Mon, 18 Mar 2019 13:08:26 -0400	[thread overview]
Message-ID: <20190318170826.GC25848@joraj-alpa> (raw)
In-Reply-To: <20190318165803.10375-1-raj.khem@gmail.com>

Hi Khem,

This looks good, still please take some moment to read this thread from musl
mailing list regarding lttng-ust usage of _SC_NPROCESSORS_CONF. For now I would
maintain the disabling of lttng-ust when musl is used. I should have CC'ed you,
I forgot.

The modification for riscv64 seems good to me. We do support lttng-* for
riscv64 [2] on debian.

[1] https://www.openwall.com/lists/musl/2019/03/15/5
[2] https://packages.debian.org/sid/utils/lttng-tools


On Mon, Mar 18, 2019 at 09:58:01AM -0700, Khem Raj wrote:
> Latest version compiles on musl as well as on risv64 now
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-kernel/lttng/lttng-modules_2.10.8.bb | 2 +-
>  meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb   | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-kernel/lttng/lttng-modules_2.10.8.bb b/meta/recipes-kernel/lttng/lttng-modules_2.10.8.bb
> index 086254d3d3..15e75e51c9 100644
> --- a/meta/recipes-kernel/lttng/lttng-modules_2.10.8.bb
> +++ b/meta/recipes-kernel/lttng/lttng-modules_2.10.8.bb
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=c4613d1f8a9587bd7b366191830364b3 \
>  
>  inherit module
>  
> -COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips|nios2|arm).*-linux'
> +COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips|nios2|arm|riscv).*-linux'
>  
>  #https://lttng.org/files/lttng-modules/lttng-modules-2.10.7.tar.bz2
>  SRC_URI = "https://lttng.org/files/${BPN}/${BPN}-${PV}.tar.bz2 \
> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb b/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
> index 151e35e3c3..d544f8e206 100644
> --- a/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
> @@ -26,9 +26,7 @@ PACKAGECONFIG[python] = "--enable-python-bindings ${PYTHON_OPTION},,python3 swig
>  PACKAGECONFIG[lttng-ust] = "--with-lttng-ust, --without-lttng-ust, lttng-ust"
>  PACKAGECONFIG[kmod] = "--with-kmod, --without-kmod, kmod"
>  PACKAGECONFIG[manpages] = "--enable-man-pages, --disable-man-pages, asciidoc-native xmlto-native libxslt-native"
> -PACKAGECONFIG_remove_libc-musl = "lttng-ust"
>  PACKAGECONFIG_remove_arc = "lttng-ust"
> -PACKAGECONFIG_remove_riscv64 = "lttng-ust"
>  
>  SRC_URI = "https://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \
>             file://x32.patch \
> -- 
> 2.21.0
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Jonathan Rajotte-Julien
EfficiOS


  parent reply	other threads:[~2019-03-18 17:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 16:58 [PATCH 1/3] lttng: Enable on musl and riscv Khem Raj
2019-03-18 16:58 ` [PATCH 2/3] packagegroup-core-tools-profile: Do not remove lttng-ust for musl and risc-v Khem Raj
2019-03-18 17:12   ` Jonathan Rajotte-Julien
2019-03-18 16:58 ` [PATCH 3/3] gdb: Do not disable lttng-ust on risc-v Khem Raj
2019-03-18 17:11   ` Jonathan Rajotte-Julien
2019-03-19 20:37     ` Jonathan Rajotte-Julien
2019-03-18 17:08 ` Jonathan Rajotte-Julien [this message]
2019-03-18 17:12   ` [PATCH 1/3] lttng: Enable on musl and riscv Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190318170826.GC25848@joraj-alpa \
    --to=jonathan.rajotte-julien@efficios.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox