Re: [PATCH] wget: Convert EXTRA_OECONF to PACKAGECONFIG, extend PACKAGECONFIG

[Adrian Bunk <bunk@stusta.de>]

On Sat, Mar 23, 2019 at 08:29:51PM +0000, Alex Kiernan wrote:
> Convert existing EXTRA_OECONF and DEPENDS to PACKAGECONFIG, fill out
> remaining PACKAGECONFIG options. Note we pass in --without-libpsl, which
> we didn't previously, but all this actually ends up doing is silencing a
> warning from the configure script, the code still uses an internal
> implemention when using this option.
> 
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
> ---
> 
>  meta/recipes-extended/wget/wget.inc | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes-extended/wget/wget.inc
> index 3cff656a68d9..99af039f417a 100644
> --- a/meta/recipes-extended/wget/wget.inc
> +++ b/meta/recipes-extended/wget/wget.inc
>...
> -EXTRA_OECONF = "--with-ssl=gnutls --disable-rpath --disable-iri \
> -                --without-libgnutls-prefix ac_cv_header_uuid_uuid_h=no"
> +EXTRA_OECONF = "--without-libgnutls-prefix --without-libssl-prefix \
> +                --disable-rpath ac_cv_header_uuid_uuid_h=no"
>...
> +PACKAGECONFIG[libuuid] = "--with-libuuid,--without-libuuid,util-linux"
>...

Can't the ac_cv_header_uuid_uuid_h hack be removed when this is now 
handled with PACKAGECONFIG?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed