From: Adrian Bunk <bunk@stusta.de>
To: akuster808 <akuster808@gmail.com>
Cc: "yocto@yoctoproject.org" <yocto@yoctoproject.org>,
OpenEmbedded Devel List
<openembedded-devel@lists.openembedded.org>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: Git commit process question.
Date: Tue, 2 Apr 2019 09:51:21 +0300 [thread overview]
Message-ID: <20190402065121.GA31468@localhost> (raw)
In-Reply-To: <a1416fe3-04fb-1d37-eaef-05b9a838254e@gmail.com>
On Mon, Apr 01, 2019 at 04:20:41PM -0700, akuster808 wrote:
>
>
> On 4/1/19 4:02 PM, Richard Purdie wrote:
> > On Mon, 2019-04-01 at 15:33 -0700, akuster808 wrote:
> >> Hello,
> >>
> >> I have noticed a large number of git commits with no header
> >> information being accepted.
> > Can you be more specific about what "no header information" means? You
> > mean a shortlog and no full log message?
> Commits with just a "subject" and signoff. No additional information
>
> We tend to reference back to how the kernel does things.
>
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> These two sections in particular.
>
>
> 2) Describe your changes
>
> Describe your problem. Whether your patch is a one-line bug fix or 5000
> lines of a new feature, there must be an underlying problem that
> motivated you to do this work. Convince the reviewer that there is a
> problem worth fixing and that it makes sense for them to read past the
> first paragraph.
>...
The kernel does not have "upgrade foo to the latest upstream version" commits.
With the Automatic Upgrade Helper this is a semi-automatic task, and
most of the time there is no specific motivation other than upgrading
to the latest upstream version.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2019-04-02 6:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 22:33 Git commit process question akuster808
2019-04-01 23:02 ` Richard Purdie
2019-04-01 23:20 ` akuster808
2019-04-01 23:41 ` Mark Hatle
2019-04-02 4:45 ` Jon Mason
2019-04-02 19:47 ` Tom Rini
2019-04-02 21:24 ` [oe] " akuster808
2019-04-03 0:45 ` Tom Rini
2019-04-03 3:51 ` Jon Mason
2019-04-02 6:51 ` Adrian Bunk [this message]
2019-04-02 19:46 ` Tom Rini
2019-04-02 20:58 ` akuster808
2019-04-03 9:34 ` Adrian Bunk
2019-04-03 10:30 ` [oe] " Burton, Ross
2019-04-03 10:38 ` Alexander Kanavin
2019-04-03 11:38 ` [yocto] " akuster808
2019-04-03 14:41 ` Tom Rini
2019-04-03 16:46 ` Khem Raj
2019-04-03 23:07 ` [yocto] " Paul Eggleton
2019-04-04 0:38 ` Khem Raj
2019-04-04 10:50 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402065121.GA31468@localhost \
--to=bunk@stusta.de \
--cc=akuster808@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=openembedded-devel@lists.openembedded.org \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox