Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: paul@betafive.co.uk
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] strace: Fix aarch64 build with musl
Date: Wed, 8 May 2019 16:02:49 +0300	[thread overview]
Message-ID: <20190508130249.GA25917@localhost> (raw)
In-Reply-To: <20190508115836.15758-3-paul@betafive.co.uk>

On Wed, May 08, 2019 at 11:58:36AM +0000, paul@betafive.co.uk wrote:
>...
> +--- strace-4.26.orig/strace.c
> ++++ strace-4.26/strace.c
> +@@ -26,7 +26,7 @@
> + #include <locale.h>
> + #include <sys/utsname.h>
> + #ifdef HAVE_PRCTL
> +-# include <sys/prctl.h>
> ++# include <linux/prctl.h>
> + #endif
> + #include <asm/unistd.h>
> diff --git a/meta/recipes-devtools/strace/strace_4.26.bb b/meta/recipes-devtools/strace/strace_4.26.bb
> index 24f92c99e5..b71122babf 100644
> --- a/meta/recipes-devtools/strace/strace_4.26.bb
> +++ b/meta/recipes-devtools/strace/strace_4.26.bb
> @@ -15,6 +15,7 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
>             file://0001-caps-abbrev.awk-fix-gawk-s-path.patch \
>             file://0001-tests-sigaction-Check-for-mips-and-alpha-before-usin.patch \
>             file://0001-mips-o32-fix-build.patch \
> +           file://musl-fixes-armv8.patch \
>             "
>...

#include <sys/prctl.h> is the documented way for getting the prototype 
of prctl(), which cannot be in linux/prctl.h for obvious reasons.

This patch creates the following problem:

../strace-4.26/strace.c: In function 'startup_child':
../strace-4.26/strace.c:1355:3: warning: implicit declaration of function 'prctl' [-Wimplicit-function-declaration]
   prctl(PR_SET_PTRACER, PR_SET_PTRACER_ANY);
   ^~~~~


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



  reply	other threads:[~2019-05-08 13:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 11:58 [PATCH 0/2] Fix strace & gdb build on aarch64/musl paul
2019-05-08 11:58 ` [PATCH 1/2] gdb: Fix aarch64 build with musl paul
2019-05-08 11:58 ` [PATCH 2/2] strace: " paul
2019-05-08 13:02   ` Adrian Bunk [this message]
2019-05-09 10:13     ` Paul Barker
2019-05-09 12:08       ` Paul Barker
2019-05-09 13:43         ` Richard Purdie
2019-05-09 13:48           ` Bruce Ashfield
2019-05-09 14:00             ` Paul Barker
2019-05-09 14:07               ` Bruce Ashfield
2019-05-09 14:10                 ` Paul Barker
2019-05-09 14:31           ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190508130249.GA25917@localhost \
    --to=bunk@stusta.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul@betafive.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox