Re: [PATCH v2] ofono: upgrade 1.25 -> 1.29

[Adrian Bunk <bunk@stusta.de>]

On Thu, May 09, 2019 at 06:48:38AM +0000, Mittal, Anuj wrote:
> This is failing with error:
> 
> | In file included from ../ofono-1.29/ell/random.c:34:
> | ../ofono-1.29/ell/missing.h:59:20: error: static declaration of
> 'explicit_bzero' follows non-static declaration
> |  static inline void explicit_bzero(void *s, size_t n)
> |                     ^~~~~~~~~~~~~~
> | In file included from ../ofono-1.29/ell/util.h:26,
> |                  from ../ofono-1.29/ell/private.h:26,
> |                  from ../ofono-1.29/ell/random.c:33:
> | /home/pokybuild/yocto-worker/musl-qemux86-
> 64/build/build/tmp/work/core2-64-poky-linux-musl/ofono/1.29-r0/recipe-
> sysroot/usr/include/string.h:85:6: note: previous declaration of
> 'explicit_bzero' was here
> |  void explicit_bzero (void *, size_t);
> |       ^~~~~~~~~~~~~~
> | make[1]: *** [ell/random.lo] Error 1
> | make[1]: *** Waiting for unfinished jobs....
> 
> Logs here:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/578/steps/7/logs/step1b

Thanks, got a fix for that one now.

The next problem is that musl does not currently provide 
TEMP_FAILURE_RETRY, and the correct fix for that will be
that I'll try to get this fixed in musl instead of creating
yet another copy of the glibc macro.

I'll come back to ofono after that.

> Thanks,
> 
> Anuj

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed