Re: [PATCH] autotools.bbclass: output failed config.log

[Adrian Bunk <bunk@stusta.de>]

On Wed, May 15, 2019 at 05:50:44PM +0800, Hongxu Jia wrote:
> On 5/15/19 5:32 PM, Andreas Müller wrote:
> > > --- a/meta/classes/autotools.bbclass
> > > +++ b/meta/classes/autotools.bbclass
> > > @@ -90,7 +90,11 @@ oe_runconf () {
> > >                  bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
> > >                  if ! ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@"; then
> > >                          bbnote "The following config.log files may provide further information."
> > > -                       bbnote `find ${B} -ignore_readdir_race -type f -name config.log`
> > > +                       config_log="`find ${B} -ignore_readdir_race -type f -name config.log`"
> > > +                       bbnote "$config_log"
> > > +                       [ -e "$config_log" ] && cat "$config_log" | while read line; do
> > > +                               bbnote "$line"
> > > +                       done
> > >                          bbfatal_log "configure failed"
> > >                  fi
> > >          else
> > > --
> > > 2.7.4
> > > 
> > That output is useful only sometimes and extremly verbose. I'd suggest
> > to introduce a switch to enable/disable (even as newbie user I am able
> > to find config.log). How about making autobuilder's WORKDIR
> > accessible?
> 
> The output only happens while do_configure failure, it does nothing when
> build succeed,
> 
> while failure occurs, I believe related message is the more the better.
> 
> The autobuilder is just an example, for community development, it is hard to
> login
> 
> others build host to debug issue, and we have to take time to reproduce it
> 
> if we could trace it with a simple glance from the log, why not

The end of config.log often contains expected error messages completely 
unrelated to the actual problem.

Debian autobuilders already dump config.log when when configuring failed,
and there it is a common problem that people end up searching for the 
problem in the wrong places due to that.

If possible, it would therefore be better to make it accessible separately.

> //Hongxu

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed