Re: [PATCH] vim: Rework things so vim adds features not vim-tiny removes

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On Sat, May 18, 2019 at 03:03:27PM -0400, Tom Rini wrote:
> On Sat, May 18, 2019 at 08:57:02PM +0200, Martin Jansa wrote:
> > Thanks Tom for quick update.
> > 
> > ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
> > ALTERNATIVE_LINK_NAME[xxd] = "${bindir}/xxd"
> > looks strange, IIRC TARGET and LINK_NAME should always point to different
> > filepath, it was added in meta-oe commit:
> > 
> > commit 897c10b7c17c138a85bdeb36cf72e7201daf0e0e
> > Author: Dan McGregor <dan.mcgregor@usask.ca>
> > Date:   Thu Oct 18 09:46:27 2018 -0600
> > 
> >     vim: alternatify xxd
> > 
> >     toybox also provides xxd.
> > 
> > but I wonder what u-a does (or is supposed to do in this scenario). Maybe
> > u-a bbclass automatically adds .${BPN} suffix to TARGET and renames the
> > installed file?
> 
> I'll double check, but also toybox doesn't have anything for xxd today,
> so I'll add that into my build and come up with something sane for both
> if needed, thanks!

OK, so busybox, toybox and vim all provide "xxd" and busybox/toybox
setup u-a with their normal method.  With what vim has (today and also
with this patch) we end up with /usr/bin/xxd.vim, which is what we want.
I inspected the ipk for that, and then putting all 3 in
core-image-minimal looks sane too.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]