Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Armin Kuster <akuster808@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 02/15] shadow: Backport last change reproducibility
Date: Tue, 21 May 2019 08:49:17 +0300	[thread overview]
Message-ID: <20190521054917.GB9971@localhost> (raw)
In-Reply-To: <d7dac4925b2fcdacac2758a556ebdefaae4af1ee.1558402534.git.akuster808@gmail.com>

On Mon, May 20, 2019 at 06:43:04PM -0700, Armin Kuster wrote:
>...
> ++#ifdef HAVE_SECURE_GETENV
> ++#  define shadow_getenv(name) secure_getenv(name)
> ++# else
> ++#  define shadow_getenv(name) getenv(name)
> ++#endif
>...

If I understand the upstream discussion correctly,
combined with the other changes this does create
a security vulnerability in musl builds.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



  reply	other threads:[~2019-05-21  5:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  1:43 [PATCH 00/15] Warrior review request Armin Kuster
2019-05-21  1:43 ` [PATCH 01/15] gdb: Fix aarch64 build with musl Armin Kuster
2019-05-21  5:34   ` Adrian Bunk
2019-05-21  1:43 ` [PATCH 02/15] shadow: Backport last change reproducibility Armin Kuster
2019-05-21  5:49   ` Adrian Bunk [this message]
2019-05-21  1:43 ` [PATCH 03/15] oeqa/runner: Fix subunit setupClass/setupModule failure handling Armin Kuster
2019-05-21  1:43 ` [PATCH 04/15] oeqa/concurrenttest: Patch subunit module to handle classSetup failures Armin Kuster
2019-05-21  1:43 ` [PATCH 05/15] bitbake.conf: set NO_RECOMMENDATIONS with weak assignment Armin Kuster
2019-05-21  1:43 ` [PATCH 06/15] openssh: recommend rng-tools with sshd Armin Kuster
2019-05-21  1:43 ` [PATCH 07/15] oeqa/sdk: use bash to execute SDK test commands Armin Kuster
2019-05-21  1:43 ` [PATCH 08/15] run-postinsts: Fix full execution of scripts at first boot Armin Kuster
2019-05-21  1:43 ` [PATCH 09/15] oeqa/target/ssh: Replace suggogatepass with ignoring errors Armin Kuster
2019-05-21  1:43 ` [PATCH 10/15] oeqa/targetcontrol.py: fix qemuparams not work in runqemu with launch_cmd Armin Kuster
2019-05-21  1:43 ` [PATCH 11/15] wic/bootimg-efi: replace hardcoded volume name with label Armin Kuster
2019-05-21  1:43 ` [PATCH 12/15] glib-networking: add PACKAGECONFIG for openssl Armin Kuster
2019-05-21  1:43 ` [PATCH 13/15] perf: make sure that the tools/include/uapi/asm-generic directory exists Armin Kuster
2019-05-21  1:43 ` [PATCH 14/15] core-image-sato-sdk-ptest: Tweak size to stay within 4GB limit Armin Kuster
2019-05-21  1:43 ` [PATCH 15/15] kernel.bbclass: adjust a condition checking Armin Kuster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521054917.GB9971@localhost \
    --to=bunk@stusta.de \
    --cc=akuster808@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox