From: Adrian Bunk <bunk@stusta.de>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] elfutils: Fix eu-* utils builds for musl
Date: Wed, 22 May 2019 09:49:09 +0300 [thread overview]
Message-ID: <20190522064909.GA9621@localhost> (raw)
In-Reply-To: <20190522013228.7591-3-raj.khem@gmail.com>
On Tue, May 21, 2019 at 06:32:28PM -0700, Khem Raj wrote:
>...
> PN and PN-binutils is not empty anymore on musl
>...
> ++#if !defined(FNM_EXTMATCH)
> ++# define FNM_EXTMATCH (1 << 5) /* Use ksh-like extended matching. */
> ++#endif
>...
This might fix the compilation, but it is horribly wrong.
It passes a flag to a function that this function does not understand.
In the best case the function returns with an error on unknown flags.
In the worst case the function does silently something different from
what the caller expects it to do.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2019-05-22 6:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 1:32 [PATCH 1/3] musl-obstack: Add recipe Khem Raj
2019-05-22 1:32 ` [PATCH 2/3] maintainers: Account for musl-obstack and libssp-nonshared Khem Raj
2019-05-22 1:32 ` [PATCH 3/3] elfutils: Fix eu-* utils builds for musl Khem Raj
2019-05-22 6:49 ` Adrian Bunk [this message]
2019-05-22 23:29 ` Khem Raj
2019-05-23 6:10 ` Adrian Bunk
2019-05-23 13:52 ` Khem Raj
2019-05-23 15:37 ` Adrian Bunk
2019-05-22 11:10 ` [PATCH 1/3] musl-obstack: Add recipe Richard Purdie
2019-05-22 15:39 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522064909.GA9621@localhost \
--to=bunk@stusta.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox