Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] lrzsz: Add implicit declaration fixes from Debian
Date: Wed, 5 Jun 2019 10:18:31 +0200	[thread overview]
Message-ID: <20190605081831.GA1448@jama> (raw)
In-Reply-To: <20190603064703.17474-1-bunk@stusta.de>

[-- Attachment #1: Type: text/plain, Size: 2584 bytes --]

On Mon, Jun 03, 2019 at 09:47:02AM +0300, Adrian Bunk wrote:
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> --

You need one more dash here, now this v2 comment ended in final commit message
which I believe wasn't the intention.

http://git.openembedded.org/openembedded-core/commit/?id=6fa60ac102f6d3977df4236bd5a22680298bdac2

the same with tcp-wrappers change:
http://git.openembedded.org/openembedded-core/commit/?id=cd1dc2334fd3e3d1db9be1d26e888051e3f59c5a

> v2: Add comment in the patch header.
> ---
>  .../lrzsz/lrzsz-0.12.20/include.patch         | 25 +++++++++++++++++++
>  meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb       |  1 +
>  2 files changed, 26 insertions(+)
>  create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
> 
> diff --git a/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
> new file mode 100644
> index 0000000000..5fcb3aa92b
> --- /dev/null
> +++ b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
> @@ -0,0 +1,25 @@
> +Implicit declaration compile warning fixes from Debian
> +
> +Signed-off-by: Adrian Bunk <bunk@stusta.de>
> +Upstream-Status: Inappropriate [upstream is dead]
> +
> +--- lrzsz-0.12.21.orig/lib/long-options.c
> ++++ lrzsz-0.12.21/lib/long-options.c
> +@@ -22,6 +22,7 @@
> + #endif
> + 
> + #include <stdio.h>
> ++#include <stdlib.h>
> + #include <getopt.h>
> + #include "long-options.h"
> + 
> +--- lrzsz-0.12.21.orig/src/lsyslog.c
> ++++ lrzsz-0.12.21/src/lsyslog.c
> +@@ -22,6 +22,7 @@
> + #ifdef ENABLE_SYSLOG
> + #include "zglobal.h"
> + #include <pwd.h>
> ++#include <stdio.h>
> + #include <stdlib.h>
> + #include <string.h>
> + #endif
> diff --git a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
> index 002c774c6d..34556b2c29 100644
> --- a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
> +++ b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
> @@ -20,6 +20,7 @@ SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \
>  	   file://lrzsz_fix_for_automake-1.12.patch \
>             file://lrzsz-check-locale.h.patch \
>             file://cve-2018-10195.patch \
> +           file://include.patch \
>             "
>  
>  SRC_URI[md5sum] = "b5ce6a74abc9b9eb2af94dffdfd372a4"
> -- 
> 2.17.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

  reply	other threads:[~2019-06-05  8:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03  6:47 [PATCH] lrzsz: Add implicit declaration fixes from Debian Adrian Bunk
2019-06-05  8:18 ` Martin Jansa [this message]
2019-06-05  9:29   ` Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2019-06-01 21:58 Adrian Bunk
2019-06-02 10:36 ` Richard Purdie
2019-06-03  6:47   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605081831.GA1448@jama \
    --to=martin.jansa@gmail.com \
    --cc=bunk@stusta.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox