Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] mtd-utils: upgrade 2.0.2 -> 2.1.0
Date: Wed, 12 Jun 2019 18:23:38 -0400	[thread overview]
Message-ID: <20190612222338.GN2112@denix.org> (raw)
In-Reply-To: <20190612053326.GA12642@localhost>

On Wed, Jun 12, 2019 at 08:33:26AM +0300, Adrian Bunk wrote:
> On Tue, Jun 11, 2019 at 05:41:52PM -0400, Denys Dmytriyenko wrote:
> >...
> > * Now requires openssl:
> > | In file included from ../git/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c:25:
> > | ../git/ubifs-utils/mkfs.ubifs/mkfs.ubifs.h:49:10: fatal error: openssl/rand.h: No such file or directory
> > |  #include <openssl/rand.h>
> > |           ^~~~~~~~~~~~~~~~
> > | compilation terminated.
> > | Makefile:3457: recipe for target 'ubifs-utils/mkfs.ubifs/mkfs_ubifs-mkfs.ubifs.o' failed
> > | make: *** [ubifs-utils/mkfs.ubifs/mkfs_ubifs-mkfs.ubifs.o] Error 1
> >...
> > -DEPENDS = "zlib e2fsprogs util-linux"
> > +DEPENDS = "zlib e2fsprogs util-linux openssl"
> 
> It doesn't (and should not) require it unconditionally.
> 
> Please backport "mkfs.ubifs: fix build without openssl" from
> upstream git instead.
> 
> >...
> > -PV = "2.0.2+${SRCPV}"
> > +PV = "2.1.0+${SRCPV}"
> >...
> 
> This was already wrong before but now is an opportunity to fix:
> Since this is exactly the release, it should be
>   PV = "2.1.0"

So, which is it? Do you want it to be exactly the release, or do you want 
to start backporting fixes from after the release? It doesn't seem to be 
a critical issue to warrant backporting, in my opinion.

-- 
Denys


  reply	other threads:[~2019-06-12 22:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 21:41 [PATCH] mtd-utils: upgrade 2.0.2 -> 2.1.0 Denys Dmytriyenko
2019-06-12  5:33 ` Adrian Bunk
2019-06-12 22:23   ` Denys Dmytriyenko [this message]
2019-06-12 22:26     ` Richard Purdie
2019-06-18  1:30       ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612222338.GN2112@denix.org \
    --to=denis@denix.org \
    --cc=bunk@stusta.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox