From: Adrian Bunk <bunk@stusta.de>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/4] gtk-icon-cache.bbclass: Depends on gtk+3
Date: Thu, 20 Jun 2019 11:28:58 +0300 [thread overview]
Message-ID: <20190620082858.GC27107@localhost> (raw)
In-Reply-To: <b7589dd06670ead7a2ca7e8c7301b289e2543249.1561018476.git.liezhi.yang@windriver.com>
On Thu, Jun 20, 2019 at 04:15:26PM +0800, Robert Yang wrote:
> The gtk-update-icon-cache and gdk-pixbuf-query-loaders are provided by gtk+3.
gdk-pixbuf-query-loaders is provided by gdk-pixbuf,
which is not tied to a specific GTK version.
gtk-update-icon-cache is provided by both GTK 2 and GTK 3,
I haven't checked whether it will also be in GTK 4.
>...
> --- a/meta/classes/gtk-icon-cache.bbclass
> +++ b/meta/classes/gtk-icon-cache.bbclass
> @@ -4,6 +4,11 @@ DEPENDS +=" ${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk
>
> PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
>
> +inherit distro_features_check
> +ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
> +
> +DEPENDS += "gtk+3"
>...
This looks OK.
> @@ -45,10 +50,11 @@ python populate_packages_append () {
> if not os.path.exists(icon_dir):
> continue
>
> - bb.note("adding hicolor-icon-theme dependency to %s" % pkg)
> - rdepends = ' ' + d.getVar('MLPREFIX', False) + "hicolor-icon-theme"
> - d.appendVar('RDEPENDS_%s' % pkg, rdepends)
> -
> + for dep in ('hicolor-icon-theme', 'gtk+3'):
> + bb.note("Adding %s dependency to %s" % (dep, pkg))
> + rdepends = ' ' + d.getVar('MLPREFIX', False) + dep
> + d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>...
Why is this necessary?
I would expect there to always be a generated RDEPENDS on either
gtk+ or gtk+3 (or soon gtk4) that already covers this.
Anything I miss here?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2019-06-20 8:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 8:15 [PATCH 0/4] meta: 4 fixes Robert Yang
2019-06-20 8:15 ` [PATCH 1/4] linux-dummy: Add do_compile_kernelmodules Robert Yang
2019-06-20 8:15 ` [PATCH 2/4] make-mod-scripts: Depends on bison-native Robert Yang
2019-06-20 8:15 ` [PATCH 3/4] update-alternatives.bbclass: run update-alternatives firstly in postinst script Robert Yang
2019-06-20 15:33 ` Richard Purdie
2019-06-21 9:20 ` Robert Yang
2019-06-20 8:15 ` [PATCH 4/4] gtk-icon-cache.bbclass: Depends on gtk+3 Robert Yang
2019-06-20 8:28 ` Adrian Bunk [this message]
2019-06-20 8:46 ` Robert Yang
2019-06-20 9:19 ` Adrian Bunk
2019-06-20 9:52 ` Alexander Kanavin
2019-06-20 9:58 ` Robert Yang
2019-06-20 13:53 ` Richard Purdie
2019-06-20 13:56 ` Burton, Ross
2019-06-21 9:48 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620082858.GC27107@localhost \
--to=bunk@stusta.de \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox