Re: [RFC][PATCH] systemd: Remove clearly incorrect musl patches

[Adrian Bunk <bunk@stusta.de>]

On Thu, Jun 20, 2019 at 11:09:39AM -0600, Khem Raj wrote:
>...
> musl has provided a lot of good cleanup patches for systemd so this is
> not a wasted
> effort even if upstream systemd does not officially support anything
> besides glibc.
>...

I have yet to see a patch that provides actual benefits for upstream,
and my overall impression of musl support patches is that they do more 
harm than good for everything except making musl build.

Like I have a WTF feeling each time !defined(__GLIBC__) is used instead 
of defined(__MUSL__) for musl-only code - as if there were only two
C libraries in the world.

You already did a lot regarding taking code from gnulib to add glibc
functionality on top of musl, and that's the direction that would
have to be followed for more functionality that is missing in musl
or where musl provides the POSIX version instead of the GNU version
of a function (e.g. strerror_r()).

All this is doable, but it's a lot of hacks and workarounds and
not much in generally useful cleanups.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed