Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Alistair Francis <alistair23@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/4] scons.bbclass: use python3-scons
Date: Mon, 24 Jun 2019 11:20:53 +0300	[thread overview]
Message-ID: <20190624082053.GB11015@localhost> (raw)
In-Reply-To: <CAKmqyKO_33RpiC4PS6vVTBUz=0Bnc7F5zbGt7mmr6VHU1rK_vA@mail.gmail.com>

On Sun, Jun 23, 2019 at 07:41:05PM -0700, Alistair Francis wrote:
> On Thu, Jun 20, 2019 at 5:22 PM Tim Orling <ticotimo@gmail.com> wrote:
> >
> >
> >
> > On Thu, Jun 20, 2019 at 6:37 AM Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> On Fri, Jun 7, 2019 at 5:50 PM Tim Orling
> >> <timothy.t.orling@linux.intel.com> wrote:
> >> >
> >> > SCons has supported python3 since 3.0.0 release, use it.
> >> >
> >> > [YOCTO #13381]
> >> >
> >> > Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> >> > ---
> >> >  meta/classes/scons.bbclass | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/meta/classes/scons.bbclass b/meta/classes/scons.bbclass
> >> > index 9ee7d1587d..a8ddae35f7 100644
> >> > --- a/meta/classes/scons.bbclass
> >> > +++ b/meta/classes/scons.bbclass
> >> > @@ -1,4 +1,4 @@
> >> > -DEPENDS += "python-scons-native"
> >> > +DEPENDS += "python3-scons-native"
> >> >
> >>
> >> some packages haven't upgraded to py3 but use scons see
> >> https://errors.yoctoproject.org/Errors/Details/249271/
> >
> >
> >
> > Thank you for reporting this. I was of course expecting some breakage and am committed to fixes. Please do report any other issues.
> 
> This also breaks the gpsd install, I tried upgrading to the latest
> release and that didn't help. I am going to send a patch for the
> upgrade which I tested with this patch reverted.

This is already workarounded:
http://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=22bfe06d15e07cac0df3f34566a9d33007663bae

There are post-3.18.1 changes required for Python 3 scons,
but I went for this hack after seeing that a proper fix
would involve all of:
1. upgrading to 3.18.1
2. rebasing oe-only patches to 3.18.1
3. adding post-3.18.1 patches

> Alistair

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



  reply	other threads:[~2019-06-24  8:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07 23:47 [PATCH 0/4] Move SCons to Python 3 Tim Orling
2019-06-07 23:47 ` [PATCH 1/4] python3-scons-{native}: add recipe for v3.0.5 Tim Orling
2019-06-08  0:56   ` Tim Orling
2019-06-07 23:47 ` [PATCH 2/4] scons.bbclass: use python3-scons Tim Orling
2019-06-20 13:36   ` Khem Raj
2019-06-21  0:18     ` Tim Orling
2019-06-21  3:27       ` Khem Raj
2019-06-22  8:58         ` Adrian Bunk
2019-06-23  0:03           ` Khem Raj
2019-06-23 16:44             ` Tim Orling
2019-06-23 19:24               ` Adrian Bunk
2019-06-24  1:49                 ` Tim Orling
2019-06-24  2:41       ` Alistair Francis
2019-06-24  8:20         ` Adrian Bunk [this message]
2019-06-24 17:27           ` Alistair Francis
2019-06-07 23:47 ` [PATCH 3/4] serf: switch to python3-scons-native Tim Orling
2019-06-10  5:10   ` Mittal, Anuj
2019-06-10  5:22     ` Tim Orling
2019-06-12 20:52     ` Khem Raj
2019-06-07 23:47 ` [PATCH 4/4] oeqa/runtime: add simple test for scons Tim Orling
2019-06-08  3:54 ` ✗ patchtest: failure for Move SCons to Python 3 Patchwork
2019-06-08  4:04   ` Tim Orling
2019-06-08  7:13 ` [PATCH 0/4] " Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190624082053.GB11015@localhost \
    --to=bunk@stusta.de \
    --cc=alistair23@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox