From: Adrian Bunk <bunk@stusta.de>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] efibootmgr: Pass correct flags to compiler from pkg-config
Date: Tue, 25 Jun 2019 11:58:40 +0300 [thread overview]
Message-ID: <20190625085840.GA17196@localhost> (raw)
In-Reply-To: <20190625060121.17379-1-raj.khem@gmail.com>
On Mon, Jun 24, 2019 at 11:01:21PM -0700, Khem Raj wrote:
> efivar.h is in usr/include/efirvar directory so it should be
> added to include search path via -I to compiler cmdline to fix
>
> make[1]: *** No rule to make target 'efivar.h', needed by 'efibootmgr.o'. Stop.
> | make[1]: *** Waiting for unfinished jobs....
>
> When running clang to generate dependencies -MM -MG -MF it still
> parses the compile unit and complains if certain header is not found
> where as gcc does not do that, hence the compile error is only seen
> when compiling with clang.
>
> FIx is use a weak default assignment for PKGS var which is used by
> pkg-config to deduce compiler flags, this helps in getting right
> -I flags even for dep step
>...
> +Upstream-Status: Pending
>...
It would be better to backport the upstream fix instead:
https://github.com/rhboot/efibootmgr/commit/97668ae0bce776a36ea2001dea63d376be8274ac
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2019-06-25 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 6:01 [PATCH v2] efibootmgr: Pass correct flags to compiler from pkg-config Khem Raj
2019-06-25 8:58 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625085840.GA17196@localhost \
--to=bunk@stusta.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox