From: Seebs <seebs@seebs.net>
To: Max Kellermann <max+openembedded@blarg.de>
Cc: Max Kellermann <max.kellermann@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH pseudo] ports/linux: wrap faccessat()
Date: Thu, 1 Aug 2019 11:17:01 -0500 [thread overview]
Message-ID: <20190801111701.367588b2@seebsdell> (raw)
In-Reply-To: <20190801160206.24078-1-max+openembedded@blarg.de>
On Thu, 1 Aug 2019 18:02:06 +0200
Max Kellermann <max+openembedded@blarg.de> wrote:
> + * wrap_access(int dirfd, const char *path, int mode, int flags) {
This should probably say "faccessat". I know it's just a comment, but
I try to be consistent about these.
> + rc = real___fxstatat64(_STAT_VER, dirfd, path, &buf, AT_SYMLINK_NOFOLLOW);
We should probably be using flags here, not AT_SYMLINK_NOFOLLOW.
Or possibly (flags & AT_SYMLINK_NOFOLLOW). Otherwise, we'll get the wrong
results if called with flags not including AT_SYMLINK_NOFOLLOW.
-s
next prev parent reply other threads:[~2019-08-01 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 16:02 [PATCH pseudo] ports/linux: wrap faccessat() Max Kellermann
2019-08-01 16:17 ` Seebs [this message]
2019-08-01 16:19 ` Max Kellermann
2019-08-01 16:20 ` [PATCH pseudo v2] " Max Kellermann
2019-08-01 16:31 ` ✗ patchtest: failure for ports/linux: wrap faccessat() (rev2) Patchwork
2019-08-01 16:31 ` ✗ patchtest: failure for ports/linux: wrap faccessat() Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801111701.367588b2@seebsdell \
--to=seebs@seebs.net \
--cc=max+openembedded@blarg.de \
--cc=max.kellermann@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox