Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Hongxu Jia <hongxu.jia@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] elfutils: 0.176 -> 0.177
Date: Fri, 23 Aug 2019 17:26:23 +0300	[thread overview]
Message-ID: <20190823142623.GA30097@localhost> (raw)
In-Reply-To: <e73ede01-3f54-232c-a97a-db4890527a7f@windriver.com>

On Fri, Aug 23, 2019 at 09:28:11AM +0800, Hongxu Jia wrote:
> On 8/23/19 1:01 AM, Adrian Bunk wrote:
> > On Thu, Aug 22, 2019 at 09:40:18AM +0800, Hongxu Jia wrote:
> > > - Update Debian patches
> > >    http://ftp.de.debian.org/debian/pool/main/e/elfutils/elfutils_0.176-1.debian.tar.xz
> > > 
> > > - Rebase Debian patches to 0.177
> > >    debian/hppa_backend.diff
> > >    debian/mips_backend.diff
> > >    debian/arm_backend.diff
> > >    debian/mips_readelf_w.patch
> > >    debian/testsuite-ignore-elflint.diff
> > >    debian/mips_cfi.patch
> > > ...
> > >   ...1-fix-compile-failure-with-debian-patches.patch |  48 ++++++++
> > > ...
> > >   .../elfutils/files/debian/hppa_backend.diff        |  57 +++++----
> > >   .../elfutils/files/debian/hurd_path.patch          |  17 +--
> > > ...
> > >   .../elfutils/files/debian/kfreebsd_path.patch      |  13 +-
> > > ...
> > >   .../elfutils/files/debian/mips_cfi.patch           | 131 +++++++++++++++++++++
> > > ...
> > Why are we following Debian patches in a package with active upstream?
> 
> I am afraid no, we need to rebase them (0.176) to 0.177

The part about rebasing existing patches is clear.

But why are we for example adding mips_cfi.patch when this is not upstream?
There might be a good reason for doing so, but "because it is a Debian patch"
is not a good reason.

And the existing hppa/hurd/kfreebsd patches from Debian are unlikely to 
make sense in OE.

> //Hongxu

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



  reply	other threads:[~2019-08-23 14:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22  1:40 [PATCH 1/3] distcc: upgrade 3.3.2 -> 3.3.3 Hongxu Jia
2019-08-22  1:40 ` [PATCH 2/3] ncurses: upgrade 6.1+20181013 -> 6.1+20190803 Hongxu Jia
2019-08-22  1:40 ` [PATCH 3/3] elfutils: 0.176 -> 0.177 Hongxu Jia
2019-08-22 13:27   ` Richard Purdie
2019-08-23  1:27     ` Hongxu Jia
2019-08-22 17:01   ` Adrian Bunk
2019-08-23  1:28     ` Hongxu Jia
2019-08-23 14:26       ` Adrian Bunk [this message]
2019-08-23 14:37         ` Hongxu Jia
2019-08-22  2:02 ` ✗ patchtest: failure for "distcc: upgrade 3.3.2 -> 3.3.3..." and 2 more Patchwork
2019-08-22  2:07   ` [PATCH V2 1/3] distcc: upgrade 3.3.2 -> 3.3.3 Hongxu Jia
2019-08-22  2:07     ` [PATCH V2 2/3] ncurses: upgrade 6.1+20181013 -> 6.1+20190803 Hongxu Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190823142623.GA30097@localhost \
    --to=bunk@stusta.de \
    --cc=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox