From: Denys Dmytriyenko <denis@denix.org>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] busybox-inittab: minor formatting tweaks
Date: Fri, 13 Sep 2019 17:19:03 -0400 [thread overview]
Message-ID: <20190913211903.GH30018@denix.org> (raw)
In-Reply-To: <20190912225624.28572-3-armccurdy@gmail.com>
On Thu, Sep 12, 2019 at 03:56:24PM -0700, Andre McCurdy wrote:
> Add an empty line to inittab before the line(s) which start getty.
>
> Also cleanup indent in recipe do_install().
>
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Reviewed-by: Denys Dmytriyenko <denys@ti.com>
> ---
> .../busybox/busybox-inittab_1.31.0.bb | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb b/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb
> index c347daf501..61fb8cbad1 100644
> --- a/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb
> +++ b/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb
> @@ -13,15 +13,16 @@ do_compile() {
> }
>
> do_install() {
> - install -d ${D}${sysconfdir}
> - install -D -m 0644 ${WORKDIR}/inittab ${D}${sysconfdir}/inittab
> - tmp="${SERIAL_CONSOLES}"
> - for i in $tmp
> - do
> - j=`echo ${i} | sed s/\;/\ /g`
> - id=`echo ${i} | sed -e 's/^.*;//' -e 's/;.*//'`
> - echo "$id::respawn:${base_sbindir}/getty ${j}" >> ${D}${sysconfdir}/inittab
> - done
> + install -d ${D}${sysconfdir}
> + install -D -m 0644 ${WORKDIR}/inittab ${D}${sysconfdir}/inittab
> + tmp="${SERIAL_CONSOLES}"
> + [ -n "$tmp" ] && echo >> ${D}${sysconfdir}/inittab
> + for i in $tmp
> + do
> + j=`echo ${i} | sed s/\;/\ /g`
> + id=`echo ${i} | sed -e 's/^.*;//' -e 's/;.*//'`
> + echo "$id::respawn:${base_sbindir}/getty ${j}" >> ${D}${sysconfdir}/inittab
> + done
> }
>
> # SERIAL_CONSOLES is generally defined by the MACHINE .conf.
> --
> 2.23.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
prev parent reply other threads:[~2019-09-13 21:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 22:56 [PATCH 1/3] busybox: drop unused mount.busybox and umount.busybox wrappers Andre McCurdy
2019-09-12 22:56 ` [PATCH 2/3] busybox: drop inittab from SRC_URI ( now moved to busybox-inittab ) Andre McCurdy
2019-09-12 22:56 ` [PATCH 3/3] busybox-inittab: minor formatting tweaks Andre McCurdy
2019-09-13 21:19 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913211903.GH30018@denix.org \
--to=denis@denix.org \
--cc=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox