Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 3/3] sanity: Add check for tar older than 1.28
Date: Thu, 21 Nov 2019 15:02:07 +0000	[thread overview]
Message-ID: <20191121150207.3657-3-richard.purdie@linuxfoundation.org> (raw)
In-Reply-To: <20191121150207.3657-1-richard.purdie@linuxfoundation.org>

Older versions break opkg-build when reproducible builds are enabled.
Rather than trying to be selective based on which features are enabled,
lets just make this a minimum version.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/sanity.bbclass | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index a14bf53883c..0179fb8c687 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -523,6 +523,7 @@ def check_wsl(d):
 
 # Tar version 1.24 and onwards handle overwriting symlinks correctly
 # but earlier versions do not; this needs to work properly for sstate
+# Version 1.28 is needed so opkg-build works correctly when reproducibile builds are enabled
 def check_tar_version(sanity_data):
     from distutils.version import LooseVersion
     import subprocess
@@ -532,7 +533,9 @@ def check_tar_version(sanity_data):
         return "Unable to execute tar --version, exit code %d\n%s\n" % (e.returncode, e.output)
     version = result.split()[3]
     if LooseVersion(version) < LooseVersion("1.24"):
-        return "Your version of tar is older than 1.24 and has bugs which will break builds. Please install a newer version of tar.\n"
+        return "Your version of tar is older than 1.24 and has bugs which will break builds. Please install a newer version of tar (1.28+).\n"
+    if LooseVersion(version) < LooseVersion("1.28"):
+        return "Your version of tar is older than 1.28 and does not have the support needed to enable reproducible builds. Please install a newer version of tar.\n"
     return None
 
 # We use git parameters and functionality only found in 1.7.8 or later
-- 
2.20.1



  parent reply	other threads:[~2019-11-21 15:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 15:02 [PATCH 1/3] opkg: Add upstream fixes Richard Purdie
2019-11-21 15:02 ` [PATCH 2/3] opkg-utils: Fix silent empty/broken opkg package creation Richard Purdie
2019-11-21 15:02 ` Richard Purdie [this message]
2019-11-21 15:50   ` [PATCH 3/3] sanity: Add check for tar older than 1.28 Adrian Bunk
2019-11-21 16:54     ` Richard Purdie
2019-11-21 17:02       ` Alexander Kanavin
2019-11-21 17:09       ` Adrian Bunk
2019-11-21 18:09         ` Richard Purdie
2019-11-21 19:14           ` Mark Hatle
2019-11-21 19:33             ` Richard Purdie
2019-11-22  0:27 ` [PATCH 1/3] opkg: Add upstream fixes Khem Raj
2019-11-22  8:58   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191121150207.3657-3-richard.purdie@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox