Re: [PATCH v2] distro_features_check: expand with MACHINE_FEATURES and COMBINED_FEATURES, rename

[Denys Dmytriyenko <denis@denix.org>]

On Fri, Nov 22, 2019 at 06:16:39PM -0500, Denys Dmytriyenko wrote:
> On Fri, Nov 22, 2019 at 11:10:14PM +0000, Richard Purdie wrote:
> > On Fri, 2019-11-22 at 23:58 +0100, Andreas Müller wrote:
> > > Whatever this patch does renaming does nothing but causing me lots of
> > > useles (rebasing) efforts. To me ist is simlpy the worst patch of
> > > this
> > > year and thanks for blocking me with this. I am really really
> > > upset!!!!!!!
> > 
> > FWIW you can probably unblock yourself by adding a local copy of the
> > compatibility bbclass with the warning removed. That will then let you
> > fix the fallout at a time of your choosing.
> 
> I thought warning would be relatively harmless... Why would it be blocking?
> Do you want this to be a notice instead?
> 
> 
> > I was in two minds about the change to be honest but nobody commented
> > in review and I get really tired of a reputation for saying "no" to
> > "everything". What probably swung the balance is the ways you can work
> > around the change at least temporarily.
> 
> I was also surprised by relative silence in review. Plus, it was in 
> master-next for over a week and nobody complained either...

And to be fair, this is almost right after the release, so is the best time 
for such invasive changes - I did wait and held off submitting it for several 
months to not disrupt the release process!
So such overreaction is rather unwarranted...

-- 
Denys