From: Adrian Bunk <bunk@stusta.de>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] swuashfs-tools: Enable on musl
Date: Fri, 14 Feb 2020 16:35:25 +0200 [thread overview]
Message-ID: <20200214143525.GA31591@localhost> (raw)
In-Reply-To: <20200214070352.1206450-1-raj.khem@gmail.com>
On Thu, Feb 13, 2020 at 11:03:52PM -0800, Khem Raj wrote:
> Upstream has a patch [1] to fix musl builds, Prior to this it would not
> build on musl due to missing GNU extentions for fnmatch
>
> [1] https://github.com/plougher/squashfs-tools/commit/4280e74de14070869787a9166242f9ce2dafd82e
>...
I did already remove a similar bogus squashfs-tools change from OE,
with similar FNM_EXTMATCH "fixes" in ifupdown and elfutils
also resulting in the expected runtime misbehaviour.
I am not a fan of this musl way of fixing build failures by turning them
into runtime breakages.
cu
Adrian
next prev parent reply other threads:[~2020-02-14 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 7:03 [PATCH] swuashfs-tools: Enable on musl Khem Raj
2020-02-14 14:35 ` Adrian Bunk [this message]
2020-02-14 14:42 ` Khem Raj
2020-02-14 15:50 ` Adrian Bunk
2020-02-14 14:49 ` Robert P. J. Day
2020-02-14 15:37 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214143525.GA31591@localhost \
--to=bunk@stusta.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox