From: Adrian Bunk <bunk@stusta.de>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
Alexander Kanavin <alex.kanavin@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 1/6] webkitgtk: Remove unnecessary REQUIRED_DISTRO_FEATURES requirements
Date: Mon, 24 Feb 2020 16:08:01 +0200 [thread overview]
Message-ID: <20200224140801.GC27036@localhost> (raw)
In-Reply-To: <20200224104635.GA27036@localhost>
On Mon, Feb 24, 2020 at 12:46:35PM +0200, Adrian Bunk wrote:
> On Mon, Feb 24, 2020 at 09:17:56AM +0000, Richard Purdie wrote:
> > On Sun, 2020-02-23 at 20:29 +0200, Adrian Bunk wrote:
> > > opengl is optional.
> > > x11 can be replaced with wayland.
> > >
> > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > > ---
> > > meta/recipes-sato/webkit/webkitgtk_2.26.4.bb | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.26.4.bb b/meta/recipes-sato/webkit/webkitgtk_2.26.4.bb
> > > index a48a976f94..51fba94964 100644
> > > --- a/meta/recipes-sato/webkit/webkitgtk_2.26.4.bb
> > > +++ b/meta/recipes-sato/webkit/webkitgtk_2.26.4.bb
> > > @@ -26,7 +26,7 @@ SRC_URI[sha256sum] = "4386900713dfadf9741177210b32623cab22562a79ffd0d446b6656993
> > >
> > > inherit cmake pkgconfig gobject-introspection perlnative features_check upstream-version-is-even gtk-doc
> > >
> > > -REQUIRED_DISTRO_FEATURES = "x11 opengl"
> > > +ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
> > >
> > > CVE_PRODUCT = "webkitgtk webkitgtk\+"
> >
> > The autobuilder no-x11 build seems unhappy with this patch series
> > unfortunately :(
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/1616
>
> Sorry for that, I did not test a wayland-only build of webkitgtk.
>
> I'll take care of that this evening, until then please drop either this
> first patch or the whole series.
OK, the short-term solution is to drop the first patch.
The original failure is easy to fix (I'll send a patch that moves the
X libraries from DEPENDS to the x11 config), but the next one is not:
Alexander, wayland support in webkitgtk requires mesa built with x11
support (otherwise gl.pc is not available).
cu
Adrian
next prev parent reply other threads:[~2020-02-24 14:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 18:29 [PATCH v2 1/6] webkitgtk: Remove unnecessary REQUIRED_DISTRO_FEATURES requirements Adrian Bunk
2020-02-23 18:29 ` [PATCH v2 2/6] webkitgtk: Remove unused DEPENDS on pulseaudio Adrian Bunk
2020-02-23 18:29 ` [PATCH v2 3/6] webkitgtk: Remove obsolete gtk2 packageconfig Adrian Bunk
2020-02-23 18:29 ` [PATCH v2 4/6] webkitgtk: Remove the unused DEPENDS on libidn Adrian Bunk
2020-02-23 18:29 ` [PATCH v2 5/6] systemd: Add a PACKAGECONFIG for libidn2 Adrian Bunk
2020-02-23 18:29 ` [PATCH v2 6/6] libidn: Move to meta-oe Adrian Bunk
2020-02-24 9:17 ` [PATCH v2 1/6] webkitgtk: Remove unnecessary REQUIRED_DISTRO_FEATURES requirements Richard Purdie
2020-02-24 10:46 ` Adrian Bunk
2020-02-24 14:08 ` Adrian Bunk [this message]
2020-02-24 14:12 ` Alexander Kanavin
2020-02-24 21:45 ` Alexander Kanavin
2020-02-25 11:19 ` Adrian Bunk
2020-02-25 11:32 ` Alexander Kanavin
2020-02-25 12:38 ` Adrian Bunk
2020-02-25 12:46 ` Martin Jansa
2020-02-26 11:50 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224140801.GC27036@localhost \
--to=bunk@stusta.de \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox