From: Adrian Bunk <bunk@stusta.de>
To: Victor Kamensky <kamensky@cisco.com>
Cc: Jens Rehsack <sno@netbsd.org>, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] make: disable use of posix_spawn on mips
Date: Sat, 29 Feb 2020 11:21:03 +0200 [thread overview]
Message-ID: <20200229092103.GA27521@localhost> (raw)
In-Reply-To: <20200229075546.12713-1-kamensky@cisco.com>
On Fri, Feb 28, 2020 at 11:55:46PM -0800, Victor Kamensky via Openembedded-core wrote:
> After make-4.3 migration child_execute_job function started
> using posix_spawn function, which happens to be broken on mips.
>
> It manifests itself as when make executed by root, it switches
> real user id to wrong value because of some issues with direct
> setresuid system call done in glibc __spawni_child function
> through inline assemble and/or gcc compiling it produces wrong
> code. I.e instead of passing -1 posix_spawn function incorrectly
> passes 127 as ruid. Subsequently job started by make can fail
> with permission issue because they run under wrong user.
Thanks for looking into this.
> For now workaround is used by explicitly disabling posix_spawn
> call use by make on mips through configure variable.
The proper fix would be to upgrade to the latest glibc 2.31 branch,
which has backported the fixes for the bug [1] on mips/risc-v/microblaze.
cu
Adrian
[1] https://sourceware.org/bugzilla/show_bug.cgi?id=25523
prev parent reply other threads:[~2020-02-29 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 7:55 [PATCH] make: disable use of posix_spawn on mips Victor Kamensky
2020-02-29 8:32 ` ✗ patchtest: failure for " Patchwork
2020-02-29 9:21 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200229092103.GA27521@localhost \
--to=bunk@stusta.de \
--cc=kamensky@cisco.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sno@netbsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox