public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Paul Barker <pbarker@konsulko.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 1/5] archiver.bbclass: Handle gitsm URLs in the mirror archiver
Date: Mon,  9 Mar 2020 14:21:35 +0000	[thread overview]
Message-ID: <20200309142139.15741-2-pbarker@konsulko.com> (raw)
In-Reply-To: <20200309142139.15741-1-pbarker@konsulko.com>

To fully archive a `gitsm://` entry in SRC_URI we need to also capture
the submodules recursively. If shallow mirror tarballs are found, they
must be temporarily extracted so that the submodules can be determined.

Signed-off-by: Paul Barker <pbarker@konsulko.com>
---
 meta/classes/archiver.bbclass | 31 ++++++++++++++++++++++++++-----
 1 file changed, 26 insertions(+), 5 deletions(-)

diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass
index 013195df7d..fef7ad4f62 100644
--- a/meta/classes/archiver.bbclass
+++ b/meta/classes/archiver.bbclass
@@ -306,7 +306,7 @@ python do_ar_configured() {
 }
 
 python do_ar_mirror() {
-    import subprocess
+    import shutil, subprocess, tempfile
 
     src_uri = (d.getVar('SRC_URI') or '').split()
     if len(src_uri) == 0:
@@ -337,12 +337,10 @@ python do_ar_mirror() {
 
     bb.utils.mkdirhier(destdir)
 
-    fetcher = bb.fetch2.Fetch(src_uri, d)
-
-    for url in fetcher.urls:
+    def archive_url(fetcher, url):
         if is_excluded(url):
             bb.note('Skipping excluded url: %s' % (url))
-            continue
+            return
 
         bb.note('Archiving url: %s' % (url))
         ud = fetcher.ud[url]
@@ -376,6 +374,29 @@ python do_ar_mirror() {
         bb.note('Copying source mirror')
         cmd = 'cp -fpPRH %s %s' % (localpath, destdir)
         subprocess.check_call(cmd, shell=True)
+
+        if url.startswith('gitsm://'):
+            def archive_submodule(ud, url, module, modpath, workdir, d):
+                url += ";bareclone=1;nobranch=1"
+                newfetch = bb.fetch2.Fetch([url], d, cache=False)
+
+                for url in newfetch.urls:
+                    archive_url(newfetch, url)
+
+            # If we're using a shallow mirror tarball it needs to be unpacked
+            # temporarily so that we can examine the .gitmodules file
+            if ud.shallow and os.path.exists(ud.fullshallow) and ud.method.need_update(ud, d):
+                tmpdir = tempfile.mkdtemp(dir=d.getVar("DL_DIR"))
+                subprocess.check_call("tar -xzf %s" % ud.fullshallow, cwd=tmpdir, shell=True)
+                ud.method.process_submodules(ud, tmpdir, archive_submodule, d)
+                shutil.rmtree(tmpdir)
+            else:
+                ud.method.process_submodules(ud, ud.clonedir, archive_submodule, d)
+
+    fetcher = bb.fetch2.Fetch(src_uri, d, cache=False)
+
+    for url in fetcher.urls:
+        archive_url(fetcher, url)
 }
 
 def exclude_useless_paths(tarinfo):
-- 
2.20.1



  reply	other threads:[~2020-03-09 14:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 14:21 [PATCH 0/5] Archiver and externalsrc fixes Paul Barker
2020-03-09 14:21 ` Paul Barker [this message]
2020-03-10 23:16   ` [PATCH 1/5] archiver.bbclass: Handle gitsm URLs in the mirror archiver Richard Purdie
2020-03-11 11:31     ` Paul Barker
2020-03-11 11:38       ` Richard Purdie
2020-03-11 11:50         ` Paul Barker
2020-03-11 11:53           ` Richard Purdie
2020-03-09 14:21 ` [PATCH 2/5] archiver.bbclass: Make do_deploy_archives a recursive dependency Paul Barker
2020-03-10 23:18   ` Richard Purdie
2020-03-11 11:40     ` Paul Barker
2020-04-01 14:49       ` [OE-core] " Mark Hatle
     [not found]       ` <1601B99892621331.16702@lists.openembedded.org>
2020-04-01 17:20         ` Mark Hatle
2020-03-09 14:21 ` [PATCH 3/5] kernelsrc.bbclass: Fix externalsrc support Paul Barker
2020-03-09 14:21 ` [PATCH 4/5] perf: " Paul Barker
2020-03-09 14:21 ` [PATCH 5/5] kernel-yocto.bbclass: Support config fragments with externalsrc Paul Barker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200309142139.15741-2-pbarker@konsulko.com \
    --to=pbarker@konsulko.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox