Re: [OE-core] [PATCH 1/2 v5] coreutils: add ptest

Richard Purdie
2020-04-06T11:58:13Z

On Sun, 2020-04-05 at 17:26 -0700, Khem Raj wrote:
> On Wed, Mar 11, 2020 at 4:33 AM Trevor Gamblin
> <trevor.gamblin@windriver.com> wrote:
> > +inherit ptest
> > +
> > +RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl libmodule-build-perl make perl perl-module-file-stat python3-core sed shadow"
> > +
>
> Adding libmodule-build-perl to rdeps here is pulling in whole target
> toolchain components now while building core-image-minimal
> the dependency chain looks like, total task building for this image are 3000+
>
> "coreutils.do_package_qa" -> "libmodule-build-perl.do_packagedata" ->
> "packagegroup-core-buildessential.do_packagedata" ->
> "gcc.do_packagedata"
>
> IMO, it's a bad experience for the user when building a simple minimal
> image and it ends up building whole toolchain for target that
> eventually won't even
> be part of the image. perhaps make it dependent on ptest or some such
> knob thats not commonly used.
>
> Please revert this patch series until we can find a way to not insert
> these build-time dependencies in normal flow.

We were aware of this when it merged. This should already only happen
if ptest is enabled?

(else ${PN}-ptest isn't in PACKAGES and hence the RDEPENDS isn't seen).

I wish we had a better way of handling these dependencies but we sadly
don't.

Cheers,

Richard