From: "Denys Dmytriyenko" <denis@denix.org>
To: Anuj Mittal <anuj.mittal@intel.com>,
Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 2/2] gstreamer1.0-plugins-good: add qt5 PACKAGECONFIG
Date: Tue, 24 Mar 2020 13:58:21 -0400 [thread overview]
Message-ID: <20200324175821.GW1578@denix.org> (raw)
In-Reply-To: <1582252918-89191-2-git-send-email-anuj.mittal@intel.com>
On Fri, Feb 21, 2020 at 10:41:58AM +0800, Anuj Mittal wrote:
> Instead of disabling unconditionally, add PACKAGECONFIG for
> qt5. Imported from meta-qt5 layer.
>
> Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
> ---
> .../gstreamer/gstreamer1.0-plugins-good_1.16.2.bb | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.2.bb
> index f3e0cee..8b34111 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.2.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.2.bb
> @@ -42,6 +42,7 @@ PACKAGECONFIG[libpng] = "-Dpng=enabled,-Dpng=disabled,libpng"
> PACKAGECONFIG[libv4l2] = "-Dv4l2-libv4l2=enabled,-Dv4l2-libv4l2=disabled,v4l-utils"
> PACKAGECONFIG[mpg123] = "-Dmpg123=enabled,-Dmpg123=disabled,mpg123"
> PACKAGECONFIG[pulseaudio] = "-Dpulse=enabled,-Dpulse=disabled,pulseaudio"
> +PACKAGECONFIG[qt5] = "-Dqt5=enabled,-Dqt5=disabled,qtbase qtdeclarative qtbase-native"
Does it make oe-core depend on meta-qt5 layer?
What is the policy here for having inter-layer dependencies in DEPENDS vs.
PACKAGECONFIG without explicitly listing them in LAYERDEPENDS?
--
Denys
> PACKAGECONFIG[soup] = "-Dsoup=enabled,-Dsoup=disabled,libsoup-2.4"
> PACKAGECONFIG[speex] = "-Dspeex=enabled,-Dspeex=disabled,speex"
> PACKAGECONFIG[taglib] = "-Dtaglib=enabled,-Dtaglib=disabled,taglib"
> @@ -50,11 +51,6 @@ PACKAGECONFIG[vpx] = "-Dvpx=enabled,-Dvpx=disabled,libvpx"
> PACKAGECONFIG[wavpack] = "-Dwavpack=enabled,-Dwavpack=disabled,wavpack"
> PACKAGECONFIG[x11] = "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}"
>
> -# qt5 support is disabled, because it is not present in OE core, and requires more work than
> -# just adding a packageconfig (it requires access to moc, uic, rcc, and qmake paths).
> -# This is better done in a separate qt5 layer (which then should add a "qt5" packageconfig
> -# in a gstreamer1.0-plugins-good bbappend).
> -
> EXTRA_OEMESON += " \
> -Daalib=disabled \
> -Ddirectsound=disabled \
> @@ -64,7 +60,6 @@ EXTRA_OEMESON += " \
> -Doss4=disabled \
> -Dosxaudio=disabled \
> -Dosxvideo=disabled \
> - -Dqt5=disabled \
> -Dshout2=disabled \
> -Dtwolame=disabled \
> -Dwaveform=disabled \
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2020-03-24 17:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 2:41 [PATCH v3 1/2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON Anuj Mittal
2020-02-21 2:41 ` [PATCH 2/2] gstreamer1.0-plugins-good: add qt5 PACKAGECONFIG Anuj Mittal
2020-03-24 17:58 ` Denys Dmytriyenko [this message]
2020-03-24 18:07 ` [OE-core] " Richard Purdie
2020-03-24 18:12 ` Denys Dmytriyenko
2020-03-24 18:15 ` Richard Purdie
2020-03-24 18:33 ` Denys Dmytriyenko
2020-03-24 18:45 ` Richard Purdie
[not found] ` <15FF5122E920BDAA.24006@lists.openembedded.org>
2020-03-24 18:43 ` Denys Dmytriyenko
2020-03-24 19:29 ` Richard Purdie
2020-03-24 19:32 ` Denys Dmytriyenko
2020-03-24 19:57 ` Richard Purdie
2020-03-24 22:12 ` Denys Dmytriyenko
2020-03-24 22:37 ` Richard Purdie
2020-04-12 18:46 ` Denys Dmytriyenko
2020-04-12 18:49 ` Richard Purdie
2020-02-21 3:01 ` ✗ patchtest: failure for "[v3] gstreamer1.0-plugins-good..." and 1 more Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324175821.GW1578@denix.org \
--to=denis@denix.org \
--cc=anuj.mittal@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox