From: "Adrian Bunk" <bunk@stusta.de>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: Stefan Ghinea <stefan.ghinea@windriver.com>,
OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] pulseaudio: fix for ARM thumb + frame pointers compilation error
Date: Thu, 26 Mar 2020 22:26:50 +0200 [thread overview]
Message-ID: <20200326202650.GA14127@localhost> (raw)
In-Reply-To: <CAJ86T=WJ4+8Ly59gxj6maeLQC5NAcZiM-G+uKqhTTi3u9C_FtQ@mail.gmail.com>
On Thu, Mar 26, 2020 at 12:53:08PM -0700, Andre McCurdy wrote:
> On Thu, Mar 26, 2020 at 12:16 PM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > On Thu, Mar 26, 2020 at 05:26:29PM +0200, Stefan Ghinea wrote:
> > >...
> > > When compiling for Thumb or Thumb2, frame pointers _must_ be disabled
> > > since the Thumb frame pointer in r7
> > >...
> >
> > How are you reproducing the problem in pulseaudio?
> >
> > This sounds like a workaround for a bug in musl that was fixed 2 years ago.
>
> The problem can show up anywhere that inline asm is trying to use r7.
> In this case it looks like:
>
> https://github.com/pulseaudio/pulseaudio/blob/master/src/pulsecore/remap_neon.c#L50
>...
After looking at the pulseaudio code I suspected the patch description
claiming pulseaudio syscall code would be the problem was rubbish, and
that this NEON code was the problem.
But when I tried to reproduce the problem it built for me with both
glibc and musl in master (the patch didn't mention that this was a
musl-only problem).
Then I saw that this was fixed in musl upstream 2 years ago:
https://git.musl-libc.org/cgit/musl/commit/?id=e3c682ab5257aaa6739ef242a9676d897370e78e
cu
Adrian
next prev parent reply other threads:[~2020-03-26 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 15:26 [PATCH] pulseaudio: fix for ARM thumb + frame pointers compilation error Stefan Ghinea
2020-03-26 17:23 ` [OE-core] " Andre McCurdy
2020-03-26 19:16 ` Adrian Bunk
2020-03-26 19:53 ` Andre McCurdy
2020-03-26 20:26 ` Adrian Bunk [this message]
2020-03-26 21:23 ` Andre McCurdy
2020-03-27 18:56 ` Adrian Bunk
2020-07-17 10:09 ` Tanu Kaskinen
2020-07-17 19:19 ` Andre McCurdy
2020-07-18 4:09 ` Tanu Kaskinen
2020-03-30 16:29 ` Tanu Kaskinen
[not found] ` <160121D94406B75D.27565@lists.openembedded.org>
2020-03-30 16:52 ` Tanu Kaskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326202650.GA14127@localhost \
--to=bunk@stusta.de \
--cc=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=stefan.ghinea@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox