public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: bkylerussell@gmail.com
To: openembedded-core@lists.openembedded.org
Cc: wesley.lindauer@gmail.com, Kyle Russell <bkylerussell@gmail.com>
Subject: [PATCH 0/1] patch: don't strip GitApplyTree patches
Date: Thu,  9 Apr 2020 00:41:15 -0400	[thread overview]
Message-ID: <20200409044116.27070-1-bkylerussell@gmail.com> (raw)

I think that the GitApplyTree patch implementation may not be quite
performing as expected when dealing with a non-default ${S} and patch
striplevels.

I'm not quite sure there aren't scenarios where we *do* want to honor
striplevel in GitApplyTree, even though it always appears to apply
patches at the repository's root, so I wanted to send this out for
feedback.

The change does at least address the scenario I encountered, but there's
probably a legitimate use case I'm missing where we need striplevel here.

Kyle Russell (1):
  patch: don't strip GitApplyTree patches

 meta/lib/oe/patch.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.1


             reply	other threads:[~2020-04-09  4:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09  4:41 bkylerussell [this message]
2020-04-09  4:41 ` [PATCH 1/1] patch: don't strip GitApplyTree patches bkylerussell
2020-04-09 10:07   ` [OE-core] " Richard Purdie
2020-04-27 20:32     ` bkylerussell
2020-04-30  0:01       ` [PATCH v2 0/1] patch.py: don't apply striplevel to git am command bkylerussell
2020-04-30  0:01         ` [PATCH v2 1/1] " bkylerussell
2020-04-10  3:44   ` [OE-core] [PATCH 1/1] patch: don't strip GitApplyTree patches Peter Kjellerstedt
2020-04-09  5:02 ` ✗ patchtest: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409044116.27070-1-bkylerussell@gmail.com \
    --to=bkylerussell@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=wesley.lindauer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox