From: "Seebs" <seebs@seebs.net>
To: "Yu, Mingli" <mingli.yu@windriver.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>,
"MacLeod, Randy" <Randy.MacLeod@windriver.com>,
"pavelmn@axis.com" <pavelmn@axis.com>
Subject: Re: [OE-core] [pseudo][PATCH] pseudo_util.c: Open file with O_CLOEXEC to avoid fd leak
Date: Thu, 9 Apr 2020 10:17:30 -0500 [thread overview]
Message-ID: <20200409101730.579e5ef9@seebsdell> (raw)
In-Reply-To: <DM6PR11MB3817CF24D3A7FF01AE0C7BD9F1C10@DM6PR11MB3817.namprd11.prod.outlook.com>
On Thu, 9 Apr 2020 06:30:37 +0000
"Yu, Mingli" <mingli.yu@windriver.com> wrote:
> We are trying to fix the issue as
> http://bugzilla.yoctoproject.org/show_bug.cgi?id=13311 stated.
Hmm. I think there's a more subtle logic bug here, and also one
of the diagnostics there is a debug message I didn't notice when I
made the commit, but it never comes up unless you run with
PSEUDO_DEBUG_FILE.
I'm gonna think about it more. I'm now about half convinced that
the patch is actually fine as-is for clients, it's just on the server
side that I think we'd see problems.
-s
prev parent reply other threads:[~2020-04-09 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 2:38 [pseudo][PATCH] pseudo_util.c: Open file with O_CLOEXEC to avoid fd leak Yu, Mingli
2020-04-09 3:02 ` ✗ patchtest: failure for " Patchwork
2020-04-09 5:25 ` [OE-core] [pseudo][PATCH] " Seebs
2020-04-09 6:30 ` Yu, Mingli
2020-04-09 15:17 ` Seebs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409101730.579e5ef9@seebsdell \
--to=seebs@seebs.net \
--cc=Randy.MacLeod@windriver.com \
--cc=mingli.yu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pavelmn@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox