From: "Denys Dmytriyenko" <denis@denix.org>
To: Otavio Salvador <otavio.salvador@ossystems.com.br>
Cc: OpenEmbedded Core Mailing List
<openembedded-core@lists.openembedded.org>,
Stefano Babic <sbabic@denx.de>, Tom Rini <trini@konsulko.com>,
Otavio Salvador <otavio@ossystems.com.br>
Subject: Re: [OE-core] [PATCH v3] u-boot: Restore valid default environment for running system
Date: Mon, 13 Apr 2020 12:09:17 -0400 [thread overview]
Message-ID: <20200413160917.GF1578@denix.org> (raw)
In-Reply-To: <CAP9ODKo+r=74d1B3Nu3aX9AfT_tgo9UN8YkzRyUki82fSJZRZQ@mail.gmail.com>
On Mon, Apr 13, 2020 at 08:47:21AM -0300, Otavio Salvador wrote:
> On Sun, Apr 12, 2020 at 6:07 PM Denys Dmytriyenko <denis@denix.org> wrote:
> > > +
> > > + # Generate the uboot-initial-env
> > > + oe_runmake -C ${S} O=${B} u-boot-initial-env
> >
> > So, why is this enabled unconditionally? Should this be in UBOOT_MAKE_TARGET?
> >
> > I use this .inc file for building different u-boot pieces by different recipes
> > (main u-boot, SPL, etc., etc.) controlling the build with UBOOT_MAKE_TARGET
> > below. Now each of those generate u-boot-initial-env and they clash in deploy.
>
> They clash? how so? it generates different filenames so should not have a clash.
Different filenames? It's always u-boot-initial-env in deploy and /etc...
I already sent a patch last night to actually do different names...
> > > This change is late in the cycle but it is critical in my opinion.
> > >
> > > The lack of default environment as well as the configuration for the
> > > tool is a regression from the previous release and this mitigates it.
> >
> > Well, I would rather live w/o env rather than unable to build u-boot at all...
>
> Please provide more information as I did not figure out what is not
> working by your report.
prev parent reply other threads:[~2020-04-13 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 0:14 [PATCH v3] u-boot: Restore valid default environment for running system Otavio Salvador
2020-04-02 8:10 ` [OE-core] " Stefano Babic
2020-04-12 21:07 ` Denys Dmytriyenko
2020-04-13 11:47 ` Otavio Salvador
2020-04-13 16:09 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413160917.GF1578@denix.org \
--to=denis@denix.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio.salvador@ossystems.com.br \
--cc=otavio@ossystems.com.br \
--cc=sbabic@denx.de \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox