From: "Denys Dmytriyenko" <denis@denix.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org,
Ovidiu Panait <ovidiu.panait@windriver.com>
Subject: Re: [OE-core] [PATCH 1/2] populate_sdk_base: Add ld.so.conf for nativesdk-binutils
Date: Thu, 7 May 2020 16:29:59 -0400 [thread overview]
Message-ID: <20200507202959.GE11927@denix.org> (raw)
In-Reply-To: <32b9edf2-a77a-65d5-8c1e-e7cb03a7d29a@gmail.com>
On Thu, May 07, 2020 at 01:20:40PM -0700, Khem Raj wrote:
>
>
> On 5/7/20 12:57 PM, Denys Dmytriyenko wrote:
> > On Thu, May 07, 2020 at 12:44:15PM -0700, Khem Raj wrote:
> >>
> >>
> >> On 5/3/20 3:51 PM, Steve Sakoman wrote:
> >>> Should I consider these two patches for dunfell LTS?
> >>>
> >>
> >> Yes I think they are fixing a problem and are safe.
> >
> > I don't think it is safe though!
> >
> > The code has been moved to create_sdk_files() which is a POSTPROCESS command
> > for SDK creation. What if SDK already provides own /etc/ld.so.conf? The code
> > just simply overwrites it.
> >
>
> but are there such usecases ? looking closely if SDK is extending the
> ld.so.conf then they should be appending to it instead of overwriting
> and same is true for this patch for master.
Exactly my point - should probably append, not overwrite.
As of usecases - I can think of a non-standard nativesdk tool that adjusts
/etc/ld.so.conf during install...
--
Denys
next prev parent reply other threads:[~2020-05-07 20:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 12:57 [PATCH 1/2] populate_sdk_base: Add ld.so.conf for nativesdk-binutils Ovidiu Panait
2020-04-28 12:57 ` [PATCH 2/2] populate_sdk_base: create_sdk_files: Use _nativesdk variants for libdir and base_libdir Ovidiu Panait
2020-05-03 22:51 ` [OE-core] [PATCH 1/2] populate_sdk_base: Add ld.so.conf for nativesdk-binutils Steve Sakoman
2020-05-07 19:44 ` Khem Raj
2020-05-07 19:57 ` Denys Dmytriyenko
2020-05-07 20:20 ` Khem Raj
2020-05-07 20:29 ` Denys Dmytriyenko [this message]
2020-05-07 23:02 ` Steve Sakoman
2020-05-08 0:13 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507202959.GE11927@denix.org \
--to=denis@denix.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=ovidiu.panait@windriver.com \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox