Re: [OE-core][PATCH] classes/buildhistory: capture package config

["Mikko Rapeli" <mikko.rapeli@bmw.de>]

On Wed, Jun 03, 2020 at 10:12:37AM +0200, Jan Luebbe wrote:
> As the PACKAGECONFIG variable has a large influence on the resulting
> package sizes and dependencies, it's useful to capture it in the
> recipe-level buildhistory. This makes it straightforward to analyze the
> impact of PACKAGECONFIG changes on the resulting image size.

Thanks, this is a good idea! I would print using full PACKAGECONFIG name
to avoid any confusion.

And this reminds me that DISTRO_FEATURES isn't logged into buildhistory either
afaik...

A generic approach for adding more variables to buildhistory would be nice.

-Mikko

> 
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> ---
>  meta/classes/buildhistory.bbclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
> index eb7295570dbd..a4288ef9e1f5 100644
> --- a/meta/classes/buildhistory.bbclass
> +++ b/meta/classes/buildhistory.bbclass
> @@ -113,6 +113,7 @@ python buildhistory_emit_pkghistory() {
>              self.packages = ""
>              self.srcrev = ""
>              self.layer = ""
> +            self.config = ""
>
>
>      class PackageInfo:
> @@ -254,6 +255,7 @@ python buildhistory_emit_pkghistory() {
>      rcpinfo.depends = sortlist(oe.utils.squashspaces(d.getVar('DEPENDS') or ""))
>      rcpinfo.packages = packages
>      rcpinfo.layer = layer
> +    rcpinfo.config = sortlist(oe.utils.squashspaces(d.getVar('PACKAGECONFIG') or ""))
>      write_recipehistory(rcpinfo, d)
>
>      pkgdest = d.getVar('PKGDEST')
> @@ -368,6 +370,7 @@ def write_recipehistory(rcpinfo, d):
>          f.write(u"DEPENDS = %s\n" %  rcpinfo.depends)
>          f.write(u"PACKAGES = %s\n" %  rcpinfo.packages)
>          f.write(u"LAYER = %s\n" %  rcpinfo.layer)
> +        f.write(u"CONFIG = %s\n" %  rcpinfo.config)
>
>      write_latest_srcrev(d, pkghistdir)
>
> -- 
> 2.27.0
> 

>