From: "Mikko Rapeli" <mikko.rapeli@bmw.de>
To: <Awais_Belal@mentor.com>
Cc: <pbarker@konsulko.com>, <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] toolchain-shar-relocate.sh: check for environment-setup beforehand
Date: Thu, 18 Jun 2020 11:28:26 +0000 [thread overview]
Message-ID: <20200618112825.GV108868@korppu> (raw)
In-Reply-To: <1592475214481.69521@mentor.com>
Hi,
On Thu, Jun 18, 2020 at 10:13:34AM +0000, Belal, Awais wrote:
> > I'd change the script to run with bash and "set -euo pipefail" to capture
> > errors like this early.
>
> The toolchain-shar-relocate script comes in through the replacement of SDK_PRE_INSTALL_COMMAND in toolchain-shar-extract so it cannot decide to use bash itself. Also, I don't think it would be a good idea to introduce a specific shell binding for such scripts.
I've come to the conclusion over the last 20 years that only way to maintain
sanity with shell scripts is "set -euxo pipefail" right after #!/bin/bash :)
Might work with other shells too but on Linux (build) systems bash is always there.
Tiny embedded targets are a different story...
But you decide which path to take in this case.
Cheers,
-Mikko
next prev parent reply other threads:[~2020-06-18 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 20:47 [PATCH] toolchain-shar-relocate.sh: check for environment-setup beforehand Awais Belal
2020-06-18 7:50 ` [OE-core] " Paul Barker
2020-06-18 8:04 ` Mikko Rapeli
2020-06-18 10:13 ` Awais Belal
2020-06-18 11:28 ` Mikko Rapeli [this message]
2020-06-18 10:09 ` Awais Belal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618112825.GV108868@korppu \
--to=mikko.rapeli@bmw.de \
--cc=Awais_Belal@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pbarker@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox