public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Adrian Bunk" <bunk@stusta.de>
To: "Peter A. Bigot" <pab@pabigot.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] bluez5: fix builds that require ell support
Date: Tue, 25 Aug 2020 14:12:04 +0300	[thread overview]
Message-ID: <20200825111204.GA19790@localhost> (raw)
In-Reply-To: <20200824194451.279731-1-pab@pabigot.com>

On Mon, Aug 24, 2020 at 02:44:51PM -0500, Peter A. Bigot wrote:
> Shortly after the recipe was updated to add ell as a mesh dependency
> the way ell was integrated into bluez5 was changed.  Add the new
> configuration options required for an external ell.
>...
> -PACKAGECONFIG[mesh] = "--enable-mesh,--disable-mesh, json-c ell"
> -PACKAGECONFIG[btpclient] = "--enable-btpclient,--disable-btpclient, ell"
> +PACKAGECONFIG[mesh] = "--enable-mesh --enable-external-ell,--disable-mesh --disable-external-ell, json-c ell"
> +PACKAGECONFIG[btpclient] = "--enable-btpclient --enable-external-ell,--disable-btpclient --disable-external-ell, ell"
>...

This won't work if exactly one these two options is enabled.

What about unconditional --enable-external-ell and ell DEPENDS instead?
It seems to link with the external ell only when necessary.

cu
Adrian

      reply	other threads:[~2020-08-25 11:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 19:44 [PATCH] bluez5: fix builds that require ell support Peter A. Bigot
2020-08-25 11:12 ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825111204.GA19790@localhost \
    --to=bunk@stusta.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=pab@pabigot.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox