Re: [OE-core] [master][PATCH v2 0/6] Allow PR Service and hash equiv togther

Richard Purdie
2020-08-26T11:48:43Z

On Wed, 2020-08-26 at 06:27 -0500, Mark Hatle wrote:
> v2:
>
> Most comments have been addressed to create a v2 version. I've refactored
> the commits to make a few things more clear, basically moving code around
> and fixing minor issues BEFORE the big patch.
>
> Before there were two patches that together implemented the PR Serv/Hash
> work. This has been combined into a single patch and the oe_nohash stuff
> has simply been removed as no longer applicable.
>
> The only comment that was NOT addressed in this was the suggestion to
> sed the pkgdata files in do_packagedata. I'm hesitent to do this as
> sed with ${...} in them has proven to be fragile for me in the past. If
> we decide that is necessary, I'd suggest we start with this set and then
> make that change after this proves to work (or not).

Sorry to keep on about this but I am worried about code readability and
trying not to let the code get too unreadable (we have to try).

Your shell expansion issue is a very valid concern. How about setting
the variables we expand late to "@XXXX@" and then using that as the
expression to sed later?

I'm also wondering if we should just inject the @XXXX@ change (instead
of the delVar) into d directly at the start of do_package itself, where
the existing bb.build.exec_func("package_get_auto_pr", d) call is?

That would then remove all the confusing localdata changes?

Cheers,

Richard